From owner-svn-src-head@freebsd.org  Thu Jun 14 08:46:25 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F06921011A94;
 Thu, 14 Jun 2018 08:46:24 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au
 [211.29.132.97])
 by mx1.freebsd.org (Postfix) with ESMTP id 6992D7DE85;
 Thu, 14 Jun 2018 08:46:24 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au
 [110.21.101.228])
 by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 2DCDF1072A1;
 Thu, 14 Jun 2018 18:46:21 +1000 (AEST)
Date: Thu, 14 Jun 2018 18:46:20 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Hans Petter Selasky <hps@selasky.org>
cc: Matthew Macy <mmacy@freebsd.org>, Ryan Libby <rlibby@freebsd.org>, 
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org, bde@freebsd.org
Subject: Re: svn commit: r335094 - head/sys/ofed/drivers/infiniband/core
In-Reply-To: <c14b6b39-22b3-cdb5-d387-829bad3509f3@selasky.org>
Message-ID: <20180614182603.U1417@besplex.bde.org>
References: <201806132330.w5DNUsrE043573@repo.freebsd.org>
 <CAHgpiFwQza_CEeu687s-HwnHPT+fcPk80nHkbU3Kn-aUM2AjHQ@mail.gmail.com>
 <CAPrugNq-dGjOhJ7PW5zniggowENW74P5ttCWH01U=AmXcj4gzA@mail.gmail.com>
 <c14b6b39-22b3-cdb5-d387-829bad3509f3@selasky.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=I9sVfJog c=1 sm=1 tr=0
 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17
 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=i7P0IqkiC3WXgPp8RoMA:9
 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 08:46:25 -0000

On Thu, 14 Jun 2018, Hans Petter Selasky wrote:

> On 06/14/18 02:03, Matthew Macy wrote:
>> On Wed, Jun 13, 2018 at 4:47 PM, Ryan Libby <rlibby@freebsd.org> wrote:
>>> On Wed, Jun 13, 2018 at 4:30 PM, Matt Macy <mmacy@freebsd.org> wrote:
>>>> Author: mmacy
>>>> Date: Wed Jun 13 23:30:54 2018
>>>> New Revision: 335094
>>>> URL: https://svnweb.freebsd.org/changeset/base/335094
>>>> 
>>>> Log:
>>>>    fix OFED build after r335053
>* ...
> Please revert this patch and fix MKDEV() in:
> compat/linuxkpi/common/include/linux/kdev_t.h
>
> Instead.
>
> The value returned by MKDEV() must be passable through MAJOR() and MINOR() to 
> restore the two arguments. Please make sure this is the case. Else the code 
> gets broken.

Are these macros for conversion of host (FreeBSD) dev_t's or target (Linux)
ones?  If for the host, then I don't see any reason not to use the host APIs.
If for the target, then they shouldn't be used with the host dev_t.  If for
a mixture, then the translations are very confusing, especially when they
are the identity, and many more macros are needed to reduce the confusion.

Bruce