From nobody Sat Jun 28 15:48:31 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTxfR4jqkz609GB; Sat, 28 Jun 2025 15:48:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTxfR3yLZz3Fct; Sat, 28 Jun 2025 15:48:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751125711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BPUEX7xpigmCGfUuqSD2jCEzR2XvgSnnNRJgA6IM+YM=; b=chjfj+WpFqWv0YH7Dl9bZN2rCNaqh1O5hWsaQ7OLdx19zX3hGFKsxabwQS+W75hdpONt/H wrGgZSsAn2ySlsq8slxpr9BQVVNFvwJbLrJCwUk9AgkXYw6XwTvMfs+6nM4RnAjK9NVBJe a+xFSin/WgG/wC54zjbQkta5h0baS19vTFS9u4e8byRi6tvcDSfn8bxU6+yW6FoK+RbWV3 +HVD7kDWxiv7By1GJXrbMpfbqkbv2TPIzkSLrg603FoXzwx49YekQ187lY/5ys0gWCMny+ Vf7KxSEvA1T1ZO/Lk963TnMRyniZf3agNQCdl+Pl57Lydfk+LuWLYnscTah6Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751125711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BPUEX7xpigmCGfUuqSD2jCEzR2XvgSnnNRJgA6IM+YM=; b=SNmyISWtmecBWtRrSyRXwEBcCzHClBY5z6ZUWwRKoRQKsKNZIlUAc1w9Tp/U7vxOHVwWAz 69gXGX74ifOOag37RnhIf2FIup0hhLH7REVXDl6/IMs7CyytmZ6GMiIetRWInZ8IpYbnt+ oaSwKQxi9tytHStoFy3PiAIZjaSeBefkxwaUQIPIo4YK2YE+VodWLfSPUoMYI6lVb6je39 CCQRkpc+98Tdnxxopwc/yP2VgXLvCgRYH1YicLblpV2uBtxXNr2ttdEL/jMcmX1vOaOWCC YLjvw8p5q+RRaNPvZeCEKj/tjPTDihkSp3GfSoyRWhgcIm2lGXzROTpV6cVJow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751125711; a=rsa-sha256; cv=none; b=NS58bOwsJIAvzAYgLjGtrn93WKsTTA7QdT9C75LaxY6lvk0nUQPZwdnpeG7m/yuf8w2ErY NH+qzmmt/td4pN6kWnuAmbpz4oAGoEEPavV5ZxF3Mkg01L9bt2xqstVo6nfIGei6DX06qv L+ss0Qil6XOITk2ArmAqOWoNN1wQaVE5DmHjr2MTeNrxjnY9SYP8q5FLs2fv/z9v1aS9Y4 524bpWWCcb0p0sexY+kXnM0FbusISNkUsJyQd5YzD1C+WRcc6Rv/7xsf3vuYyndomlUvUx yG9AA40XGmlqwASjar6MOLmCJD5V1KihlBNY1QGOTi8h0pBDtIiTWnwzPXbQdg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bTxfR3Xdkzg1N; Sat, 28 Jun 2025 15:48:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55SFmVrZ009579; Sat, 28 Jun 2025 15:48:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55SFmVIF009576; Sat, 28 Jun 2025 15:48:31 GMT (envelope-from git) Date: Sat, 28 Jun 2025 15:48:31 GMT Message-Id: <202506281548.55SFmVIF009576@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 8213c07c2058 - main - pfsync: Destroy buckets mutexes on clone destroying interface List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8213c07c20586a67bc7f7152bd7ff76c02cbc007 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=8213c07c20586a67bc7f7152bd7ff76c02cbc007 commit 8213c07c20586a67bc7f7152bd7ff76c02cbc007 Author: Zhenlei Huang AuthorDate: 2025-06-28 15:46:51 +0000 Commit: Zhenlei Huang CommitDate: 2025-06-28 15:46:51 +0000 pfsync: Destroy buckets mutexes on clone destroying interface So that the associated data with them will be freed. Reviewed by: kp Fixes: 4fc65bcbe3fb pfsync: Performance improvement MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D51063 --- sys/netpfil/pf/if_pfsync.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 31b641b43fe3..d5d77fa1ae1d 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -494,6 +494,10 @@ pfsync_clone_destroy(struct ifnet *ifp) mtx_destroy(&sc->sc_mtx); mtx_destroy(&sc->sc_bulk_mtx); + for (c = 0; c < pfsync_buckets; c++) { + b = &sc->sc_buckets[c]; + mtx_destroy(&b->b_mtx); + } free(sc->sc_buckets, M_PFSYNC); free(sc, M_PFSYNC);