From owner-svn-src-head@freebsd.org Thu Nov 30 01:22:19 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BDCBDEFCFF; Thu, 30 Nov 2017 01:22:19 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au [211.29.132.59]) by mx1.freebsd.org (Postfix) with ESMTP id 628126D23B; Thu, 30 Nov 2017 01:22:18 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id 313B71A6DAE; Thu, 30 Nov 2017 12:19:19 +1100 (AEDT) Date: Thu, 30 Nov 2017 12:19:18 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Scott Long cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326377 - in head/sys: amd64/conf arm/conf i386/conf mips/conf modules/aic7xxx/ahc modules/aic7xxx/ahd powerpc/conf sparc64/conf In-Reply-To: <201711292341.vATNfoSS054606@repo.freebsd.org> Message-ID: <20171130115317.X1349@besplex.bde.org> References: <201711292341.vATNfoSS054606@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=cK6QihWN c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=6Qs8Of_ElRUx6x6vf64A:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 01:22:19 -0000 On Wed, 29 Nov 2017, Scott Long wrote: > Log: > It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from > the standard kernels. They are still available as custom compile > options. MI NOTES still gives MI sizes for these options. It seems unlikely that these sizes are still correct even for 1 arch where they were measured on. > Modified: head/sys/amd64/conf/GENERIC > ============================================================================== > --- head/sys/amd64/conf/GENERIC Wed Nov 29 23:28:40 2017 (r326376) > +++ head/sys/amd64/conf/GENERIC Wed Nov 29 23:41:49 2017 (r326377) > @@ -123,11 +123,7 @@ device siis # SiliconImage SiI3124/SiI3132/SiI3531 > > # SCSI Controllers > device ahc # AHA2940 and onboard AIC7xxx devices > -options AHC_REG_PRETTY_PRINT # Print register bitfields in debug > - # output. Adds ~128k to driver. > device ahd # AHA39320/29320 and onboard AIC79xx devices > -options AHD_REG_PRETTY_PRINT # Print register bitfields in debug > - # output. Adds ~215k to driver. k is a bogus unit for memory sizes. NOTES has the same bug. > Modified: head/sys/i386/conf/GENERIC > ============================================================================== > --- head/sys/i386/conf/GENERIC Wed Nov 29 23:28:40 2017 (r326376) > +++ head/sys/i386/conf/GENERIC Wed Nov 29 23:41:49 2017 (r326377) > @@ -120,11 +120,6 @@ device siis # SiliconImage SiI3124/SiI3132/SiI3531 > > # SCSI Controllers > device ahc # AHA2940 and onboard AIC7xxx devices > -options AHC_REG_PRETTY_PRINT # Print register bitfields in debug > - # output. Adds ~128k to driver. > -device ahd # AHA39320/29320 and onboard AIC79xx devices > -options AHD_REG_PRETTY_PRINT # Print register bitfields in debug > - # output. Adds ~215k to driver. > device esp # AMD Am53C974 (Tekram DC-390(T)) > device hptiop # Highpoint RocketRaid 3xxx series > device isp # Qlogic family > This also removes ahd. This bug is only new on i386/GENERIC. Other arches except amd64 never had ahd. arm/conf/CRB was most broken -- it had 2 PRETTY options but neither ahc or ahd. Perhaps these old drivers don't belong in any GENERIC. Bruce