From owner-svn-src-all@FreeBSD.ORG Thu Oct 21 09:29:54 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB822106566C; Thu, 21 Oct 2010 09:29:54 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0D2E28FC1A; Thu, 21 Oct 2010 09:29:53 +0000 (UTC) Received: by wyb38 with SMTP id 38so4935593wyb.13 for ; Thu, 21 Oct 2010 02:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=SOZ5g+R5TO+TbVCZzQSHLz1wp8tlOC7pQJzEDnVzeT4=; b=daF4Bj1eRVVrJ/ZV/GNJPOq9QrPwf7EnkNBf0e1LVQqVzNOOsGi2Eq/O+ehw2jsBXg 0Lcc3iSSpB2puPg/DkdMuhFrA3At9y57NpJTJb966hgDIj8mx5T1CE66FwNIxjLH1gLb trMTo3rd/21d64Ca23ZGrpBvbhyZ5blzlRPyU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=mVJ1zX5H7rVoSM2AFhpoBFr5dEnUIfB7LBaqbS4MVEK/NqqEaOfEbfURHM51ctxHlE Xn2wK6DpQZ8uGv5gBximeQHCR5+rY8+omq0kEulfvP/yyL4N4XxN0CChBOOXZEKUCaNv tIQ0EEMd2UtLwp0DujpNZlYPQdRzZ8MXDVtY0= MIME-Version: 1.0 Received: by 10.216.164.199 with SMTP id c49mr594531wel.107.1287651728686; Thu, 21 Oct 2010 02:02:08 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.135.67 with HTTP; Thu, 21 Oct 2010 02:02:08 -0700 (PDT) In-Reply-To: <20101021085551.GC3838@garage.freebsd.pl> References: <201010202050.o9KKot6o068512@svn.freebsd.org> <20101021085551.GC3838@garage.freebsd.pl> Date: Thu, 21 Oct 2010 02:02:08 -0700 X-Google-Sender-Auth: qbKn7Uw8LYfgZhK6byvtGGqZV0c Message-ID: From: Garrett Cooper To: Pawel Jakub Dawidek Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo Subject: Re: svn commit: r214118 - in head: sbin/geom/class/eli sys/geom/eli X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2010 09:29:54 -0000 On Thu, Oct 21, 2010 at 1:55 AM, Pawel Jakub Dawidek wrot= e: > On Thu, Oct 21, 2010 at 07:25:53AM +0100, Rui Paulo wrote: >> Great work. Might be worth adding the geli commands to /etc/rc.suspend &= /etc/rc.resume. >> >> You could do something that requires the minimum user configuration, lik= e: >> >> --- >> geli list 2>&1 > /dev/null >> if [ $? -eq 0 ]; then >> =A0 =A0 =A0 geli suspend -a >> fi > > Well, this is not always safe. As I mentioned in the commit message this > will cause deadlock if geli(8) command is stored on encrypted file > system (you won't be able to resume). Good example of such situation is > when you encrypt even your root file system. I think it's pretty safe to say that if the user understands this limitation that they can add the relevant code to the end of rc.resume. Maybe rc.{resume,suspend}.local script hooks should be added for user-defined commands like this? Thanks, -Garrett