From owner-freebsd-hackers@FreeBSD.ORG Fri Jan 2 07:23:19 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A9DF87D; Fri, 2 Jan 2015 07:23:19 +0000 (UTC) Received: from mail.myota.org (mail.myota.org [85.10.206.105]) by mx1.freebsd.org (Postfix) with ESMTP id 265AD1248; Fri, 2 Jan 2015 07:23:18 +0000 (UTC) Received: from g229017217.adsl.alicedsl.de (g229017217.adsl.alicedsl.de [92.229.17.217]) (authenticated bits=128) by mail.myota.org (8.14.9/8.14.9) with ESMTP id t027MxmM059688; Fri, 2 Jan 2015 08:23:05 +0100 (CET) (envelope-from andre@fbsd.ata.myota.org) Received: from submit.client ([127.0.0.1]) by gate.local (8.14.9/8.14.9) with ESMTP id t027MwGL065837; Fri, 2 Jan 2015 08:22:58 +0100 (CET) (envelope-from andre@fbsd.ata.myota.org) Received: (from user@localhost) by gate.local (8.14.9/8.14.9/Submit) id t027MwPh065836; Fri, 2 Jan 2015 08:22:58 +0100 (CET) (envelope-from andre@fbsd.ata.myota.org) Date: Fri, 2 Jan 2015 08:22:58 +0100 From: Andre Albsmeier To: Ed Maste Subject: Re: [PATCH] Fixing panic in vt_fb_blank() if fb_size is not a multiple of fb_stride Message-ID: <20150102072258.GA65505@gate> References: <20150101192219.GA46601@voyager> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Echelon: 767, Compsec, USSS, MD4, detonator X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses! User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Not delayed on 85.10.206.105, ACL: AUTH(59), Origin: DE, OS: FreeBSD 9.x X-Greylist: Not delayed, ACL: localhost(52) X-Virus-Scanned: clamav-milter 0.98.5 at colo X-Virus-Status: Clean Cc: Andre Albsmeier , "freebsd-hackers@freebsd.org" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jan 2015 07:23:19 -0000 On Thu, 01-Jan-2015 at 19:58:49 -0500, Ed Maste wrote: > On 1 January 2015 at 14:22, Andre Albsmeier wrote: > > [Crossposting to -hackers and -x11 as this is vt and i915kms related] > > > > I can reliably crash an older notebook (Fujitsu E8310) with Intel > > graphics (GM965) by loading i915kms after having booted but only > > if vt(4) is used instead of old syscons. > > > > Reason for the crash is a page fault in vt_fb_blank() which is > > in /sys/dev/vt/hw/fb/vt_fb.c: > > > ... > > > > in vt_fb_blank() we find: > > > > for (o = info->fb_stride; o < info->fb_size; o += info->fb_stride) { > > info->copy(info, o, 0, info->fb_stride); > > } > > Thank you for the report and investigation. This is fixed in HEAD by > r268771 and r268796, which rework vt_fb_blank. There are a number of I should have looked there instead of wasting 3 hours debugging that ;-). But at least I did something against my clumsiness in debugging KLDs... > other vt(4) changes that are not in stable/9; I will see if most/all Right ;-) One thing is the ALT_BREAK_TO_DEBUGGER feature: http://lists.freebsd.org/pipermail/freebsd-hackers/2014-December/046682.html And we also need this one: http://lists.freebsd.org/pipermail/svn-src-all/2014-December/095666.html > of it may be feasibly merged back, or otherwise commit a change for > this problem. That would be great, thanks.