From owner-freebsd-net@freebsd.org Mon Aug 31 09:28:20 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A95C9C7B91 for ; Mon, 31 Aug 2015 09:28:20 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 58AFFDED; Mon, 31 Aug 2015 09:28:20 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 7E91525D37D1; Mon, 31 Aug 2015 09:28:17 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 90CA4C7704A; Mon, 31 Aug 2015 09:28:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id crphvtITpXAr; Mon, 31 Aug 2015 09:28:14 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:7515:be48:68e8:e50] (unknown [IPv6:fde9:577b:c1a9:4410:7515:be48:68e8:e50]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id DD62CC76FE0; Mon, 31 Aug 2015 09:28:12 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: A bug in udp6_input() - should use proto instead of ip6->ip6_nxt From: "Bjoern A. Zeeb" In-Reply-To: <1440993949-20698-1-git-send-email-btw@mail.ustc.edu.cn> Date: Mon, 31 Aug 2015 09:28:07 +0000 Cc: freebsd-net@freebsd.org, adrian@freebsd.org, hiren@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5FEE8C05-A25A-4A74-A8B0-4CA75A696D54@FreeBSD.org> References: <1440993949-20698-1-git-send-email-btw@mail.ustc.edu.cn> To: Tiwei Bie X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2015 09:28:20 -0000 > On 31 Aug 2015, at 04:05 , Tiwei Bie wrote: >=20 > I found a bug in udp6_input(). The 'proto' parameter should be used to > get the protocol number (UDP or UDPLITE), instead of ip6->ip6_nxt. >=20 > Because ip6->ip6_nxt may be the protocol number of extension header, > such as: >=20 > If a UDP packet is an "atomic" fragment, frag6_input() will return > directly, and ip6->ip6_nxt will be IPPROTO_FRAGMENT (if the first > extension header is the fragment header) instead of IPPROTO_UDP or > IPPROTO_UDPLITE: Hmm, that might be a bug elsewhere but atomic fragments are soon to go = away again; wish people would listen in first place; but anyway. There are more of these bugs that came with the UDP-Lite code, such as = 4mapped addresses are not handled correctly in the output path, etc. Can you open a bug for this and we can attach all the UDP-Lite fixes to = it to properly document them and get them through review in a few days = and committed? Thanks, Bjoern=