From owner-freebsd-current@FreeBSD.ORG Sun Aug 28 22:48:31 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2050716A41F for ; Sun, 28 Aug 2005 22:48:31 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [204.14.90.61]) by mx1.FreeBSD.org (Postfix) with SMTP id 097EB43D4C for ; Sun, 28 Aug 2005 22:48:29 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 44685 invoked by uid 399); 28 Aug 2005 22:48:29 -0000 Received: from localhost (HELO ?192.168.1.100?) (dougb@dougbarton.net@127.0.0.1) by localhost with SMTP; 28 Aug 2005 22:48:29 -0000 Message-ID: <43123F3B.8070002@FreeBSD.org> Date: Sun, 28 Aug 2005 15:48:27 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050726) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michael Bushkov References: <20050827170633.Y5409@stinger.cc.rsu.ru> In-Reply-To: <20050827170633.Y5409@stinger.cc.rsu.ru> X-Enigmail-Version: 0.92.0.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jacques Vidrine , freebsd-hackers@freebsd.org, freebsd-current@freebsd.org, Brooks Davis Subject: Re: [PATCH] caching daemon release and nsswitch patches X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2005 22:48:31 -0000 Michael Bushkov wrote: > Hi! I'm working on nsswitch improvement (during the Google Summer of > Code program. First off, let me say that this is very exciting stuff! I'm particularly excited about caching for the services stuff, as it will finally allow us to bring in a more complete version of the services file. I do have some comments for you, and I hope that you understand that they are in no way critical of your work, just suggestions for improvements, and ways that you can better fit into the FreeBSD code base. I'm not sure what guidelines were given to you when you started the project, but in reviewing your work the first thing I noticed was that you are not following the guidelines in the style(9) man page. You should read that page, and spend an afternoon reformatting your code to fit what is described there. The most common error you've made is not following the 80 column rule, which hopefully should be easily fixed. While one could argue with the specific items in that page, and quite possibly be right, the idea of having a style guideline is more to have a common format that we can all work towards than to have a perfect format that we can all agree on. By reformatting your code to fit this guideline you will greatly increase the chances that it will be welcomed into the tree with open arms. The other style area that you should look at is your man pages. If you look in /usr/share/examples/mdoc you will find the FreeBSD style guidelines for man pages. The line wrapping issue comes into play here as well. We generally don't go past column 60 in man pages, since that reduces CVS repo churn for corrections down the road. Also, any time you have a full stop (period) at the end of a sentence, you should start a new line. I think that you are also using some macros that I'm not familiar with, although I'm not an mdoc expert. The other area that I'm interested in is how you plan to have cached interact with DNS lookups, /etc/hosts, named, etc. If there was a project plan posted somewhere on this already and I missed it, please accept my apologies, and send along a reference. If not, I'm very interested to hear what your plans are. Regards, Doug -- This .signature sanitized for your protection