From owner-freebsd-hackers@FreeBSD.ORG  Wed Jul 27 20:05:57 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 22BCA16A41F
	for <freebsd-hackers@freebsd.org>; Wed, 27 Jul 2005 20:05:57 +0000 (GMT)
	(envelope-from samuel.pierson@gmail.com)
Received: from wproxy.gmail.com (wproxy.gmail.com [64.233.184.203])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 387A243D5E
	for <freebsd-hackers@freebsd.org>; Wed, 27 Jul 2005 20:05:54 +0000 (GMT)
	(envelope-from samuel.pierson@gmail.com)
Received: by wproxy.gmail.com with SMTP id i21so245372wra
	for <freebsd-hackers@freebsd.org>; Wed, 27 Jul 2005 13:05:53 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=dQbVg48LnRs8OSuruoGsDQrS9fnWhkEDNSt4alM1yCxqMUNJZOS7XkGOjcn3L2gCkiRRS3o70hwZRmoUhA7m5J/CnLdBgBoYIvzVjhEuOCGNmytmoCQ94fEIDlazjRi43Laez2I1IwhbeY86Zo02eIqDSogfL9lax/IqGhlv3Fo=
Received: by 10.54.67.8 with SMTP id p8mr472388wra;
	Wed, 27 Jul 2005 13:05:53 -0700 (PDT)
Received: by 10.54.144.1 with HTTP; Wed, 27 Jul 2005 13:05:53 -0700 (PDT)
Message-ID: <d9204e4c05072713055f9cec4@mail.gmail.com>
Date: Wed, 27 Jul 2005 15:05:53 -0500
From: Sam Pierson <samuel.pierson@gmail.com>
To: Sam Leffler <sam@errno.com>
In-Reply-To: <42E03E5B.80905@errno.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <200507211849.aa11934@salmon.maths.tcd.ie>
	<42E03E5B.80905@errno.com>
Cc: David Malone <dwmalone@maths.tcd.ie>,
	FreeBSD Hackers <freebsd-hackers@freebsd.org>
Subject: Re: Atheros, hardware access layer, collisions
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Sam Pierson <samuel.pierson@gmail.com>
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jul 2005 20:05:57 -0000

On 7/21/05, Sam Leffler <sam@errno.com> wrote:
> You need to set cwmin on the tx q as David describes.  Be sure to set
> the parameters you set into the hardware; check the wme update code for
> the correct logic.  For the other thing just set the tx descriptor to do
> 1 try.
>=20
>         Sam

So like in ath_tx_start:

=09ath_hal_setuptxdesc(ah, ds
=09=09, pktlen=09=09/* packet length */
=09=09, hdrlen=09=09/* header length */
=09=09, atype=09=09=09/* Atheros packet type */
=09=09, ni->ni_txpower=09/* txpower */
   -->=09      , txrate, 0=09=09/* series 0 rate/tries */  /*  originally:
txrate, try0 */
=09=09, keyix=09=09=09/* key cache index */
=09=09, sc->sc_txantenna=09/* antenna mode */
=09=09, flags=09=09=09/* flags */
=09=09, ctsrate=09=09/* rts/cts rate */
=09=09, ctsduration=09=09/* rts/cts duration */
=09);

This is still just for the first tx desc though.

The following bit then comes:

=09if (try0 !=3D ATH_TXMAXTRY)
=09=09ath_rate_setupxtxdesc(sc, an, ds, shortPreamble, rix);

Should I nix this?

-Sam