From nobody Sun Oct 26 04:13:47 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cvNYR3k6hz6DvHm; Sun, 26 Oct 2025 04:13:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cvNYR30vWz3Yh7; Sun, 26 Oct 2025 04:13:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761452027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ceni7UTP6J2x/Z18vpOIOM1Onm+5wcrkW6Hl5UEUj+8=; b=gnrNk4RKAW2whGIP7SlUBZynhjGUsofgAwYSudXpwA9oUH8jYOs7gyLU3ZNTxoV3Ttc4dq wqIEF1IyolNOS0MkAfpiRvvCsRTMLeB/6tDaIqvd3/1g2YqIzcIZd+V9aT8Q3RS+ku/Bei OxmWevbCOS0KVutPpHpXctHQyd2SeRylURFwA+Tx6jCfRJsAHISiqIQQ4Uybwbu29Dyd2C +HsMijQCcQ0WoTkHAkNofspqUG56/+iQTSzOJub7wzM5iHGBRntAfOOtzwjOpEiuVWQRUc +ubSV0mQZ+4j+0YAWhxgviYD0Qgdqm0W6CSrxlC2b+qhHYBloPnrAXUQMz9dnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761452027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ceni7UTP6J2x/Z18vpOIOM1Onm+5wcrkW6Hl5UEUj+8=; b=LVD1PQxaeWjQwucHkeDovZJjC4rYcXykq3ahxYBwV8sWH/AMh5yBK/YhvNHvNXT7Sla4OB ESTCpakk1K2pSInSYfhoSaHIaZd8yFrnFZycAcYEeVECNwxWdqekyF4NySNoknni4t95Y3 HAJLSe6Xr24l4g52OmzS+8AYoaq/3pwk4K3PoD6GKl/HS3bDVg4My3txxw15k3O6G8CiRE mUzgKVQZbmFnIg1C0ACgunrPNzHQk4HeibQ0bh8h8pQ2oA+qwqswZR6owgpJCJBcVpzUAi b4ty69q/jvhcN5hzVw4qrLQ0nXUrGpTgyWHu5xQF+OlDCcDSDTxc8ic3fCwvfA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761452027; a=rsa-sha256; cv=none; b=svrgZVMgk5+Z7olchicJ7Isq9S0S9hsk0T37pRWs7iBwFEJtTiFIrAhcs5aL1t6Mk7sAYh ZaU2LKw6QUA8qxCdpmpWqTrp3ui29UKVqbw+cMMQAaf50004k6K2VPgAhfiAruNsf7/Yg1 KOcWZyU0D6SDXXfVu7YrndwFPgXINpVXrpjqE9DnMbkwzJ7F+jRfqD+pupYqmhqKLLP86F eSr5C5Ty55LYMbf4Rsvdma9ho6sVLrXQR0arFz4OEVSNwvW7RjbT1HNt/dePTC2wVokZ3a SVRVOWdC2cSZHhqjYMo0kefSRBp8J2EqQAoPau+sxyL/9r2R9HUHSdpj8MzkKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cvNYR2RYdz2Wt; Sun, 26 Oct 2025 04:13:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59Q4DlEG077592; Sun, 26 Oct 2025 04:13:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59Q4DlPi077589; Sun, 26 Oct 2025 04:13:47 GMT (envelope-from git) Date: Sun, 26 Oct 2025 04:13:47 GMT Message-Id: <202510260413.59Q4DlPi077589@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 42cf7ea8dca0 - releng/15.0 - inet_net_test: Use int to hold expected return values from inet_net_pton List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.0 X-Git-Reftype: branch X-Git-Commit: 42cf7ea8dca0abd507965a6fe63ac07fb62060fd Auto-Submitted: auto-generated The branch releng/15.0 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=42cf7ea8dca0abd507965a6fe63ac07fb62060fd commit 42cf7ea8dca0abd507965a6fe63ac07fb62060fd Author: John Baldwin AuthorDate: 2025-10-20 18:31:41 +0000 Commit: Colin Percival CommitDate: 2025-10-26 04:13:26 +0000 inet_net_test: Use int to hold expected return values from inet_net_pton GCC warns about the sign mismatch in comparisons: lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet4::body() const': lib/libc/tests/net/inet_net_test.cc:86:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare] 86 | ATF_REQUIRE_EQ(bits, addr.bits); | ^~~~~~~~~~~~~~ lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet6::body() const': lib/libc/tests/net/inet_net_test.cc:205:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare] 205 | ATF_REQUIRE_EQ(bits, addr.bits); | ^~~~~~~~~~~~~~ Approved by: re (cperciva) Fixes: 8f4a0d2f7b96 ("libc: Import OpenBSD's inet_net_{ntop,pton}") (cherry picked from commit e1aeb58cbbc3839db93ec38ce491b7b9383d5649) (cherry picked from commit 7ffd190ae9c82e4359d8a6f6ae2d1b82e8eb6453) --- lib/libc/tests/net/inet_net_test.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libc/tests/net/inet_net_test.cc b/lib/libc/tests/net/inet_net_test.cc index 50687cac006a..60b60b152eca 100644 --- a/lib/libc/tests/net/inet_net_test.cc +++ b/lib/libc/tests/net/inet_net_test.cc @@ -50,7 +50,7 @@ ATF_TEST_CASE_BODY(inet_net_inet4) struct test_addr { std::string input; - unsigned bits; + int bits; std::string output; }; @@ -134,7 +134,7 @@ ATF_TEST_CASE_BODY(inet_net_inet6) struct test_addr { std::string input; - unsigned bits; + int bits; std::string output; };