From nobody Sat Aug 2 23:35:23 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bvfLz6bzQz63jWv; Sat, 02 Aug 2025 23:35:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bvfLz5nGFz3x7S; Sat, 02 Aug 2025 23:35:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754177723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a+/MlE1CVIyNIAa6WGHJ+yXXbLOAHhkE9xFCBeM6VVY=; b=S6dwETXqAXwEat0KI3y48Xt04g3AsYRhFdLq7mHFooQIU05zSUYvAfW9gEtEE41I7ihiAG r0jz+Mm3J3qhOMLOLj+beVWrodXxJxCiMtAx4O54GaC8T2nE7+Kdc3N/awial+xNU9WMOV /VBaOR+zmdBLEzsXxEaMPEXh5onZSKyAcE+n0eZ+36wNHlhLoJzaUOdic2CvN4DMNPsZa6 s/CTzeWFPVFlV9UwfT1lc3GLeVs7J5qE4NyGJf69gSJmDeGAvVRURuFiw1VybdNzuYCBPb RbGiZ/+kNt+Ek6HuBpKURXvmFQiPkErsNRDwdk3+ckcXfAb/Q2jAUgBgOxpU8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754177723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a+/MlE1CVIyNIAa6WGHJ+yXXbLOAHhkE9xFCBeM6VVY=; b=HTkCycgUj8M/wQwJOADQ29uQ8x2GeqhMu2hhonBT6DYxplZwdMFix34VCTkRkwZuVvDdwp Y+wZo0/1P0fwQGBPJxkUZrue3uoAVhs6GUlSoQAlENbcyBsqcAUWv8hVG907772ejvNtrY edzr88H6lVy52lbFusK4kPqe8jdR3B5KXVqCA7ZUIJhbkd1PCV+511aGNmIFtUqa30q5Vq b5yRXMNd5AEttkT3Jno+Vs/bzSJpIgSb7eNfdHExNR6xLFd2FEOZbtCZ9r6rFROX4ZQnyg FDj/gp+0W/QXrbXjoHtSBoBElc/xbb0AeBq8JObcel94AjAMOLqCT9JFMu0+LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754177723; a=rsa-sha256; cv=none; b=VhVjrBVkaZIwbIKZxGaRBsdJKhp0hpf5lyBFJzJzJjNfcCAUQN+Y8rigJ3nJrjh55vqEpp cKSPkYQkrAAyF17LQMxO9x0GnbLZOlv7xgT4DvheiBWoRlVEDP5ClglT+LfY8JIy+yE18i 5gt1YPJBIRo/9oSH79mfcb/Jxc3kOOo6tlsbNKx45DbED7Ab8P4yXZHxtGQHenK6i8kO65 4RQBw/e1MShUiOHpHoSfP+O+ubVYLkqrNRWt/VCL8GqFBoHtlneMy7HwnAK2DESoiG8it5 Lou52OSM+gbpJlUHRQHjUDVcw0wcIp8LPyc9NSTgneVbv3QQh5h4tvNjBIadzQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bvfLz5NjRzg20; Sat, 02 Aug 2025 23:35:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 572NZNmV004655; Sat, 2 Aug 2025 23:35:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 572NZNkP004652; Sat, 2 Aug 2025 23:35:23 GMT (envelope-from git) Date: Sat, 2 Aug 2025 23:35:23 GMT Message-Id: <202508022335.572NZNkP004652@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: a523d882a467 - main - vfs_syscall.c: do not take process lock around the read of P2_NO_NEW_PRIVS List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a523d882a4671040aba57549492f8df6676cb855 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=a523d882a4671040aba57549492f8df6676cb855 commit a523d882a4671040aba57549492f8df6676cb855 Author: Konstantin Belousov AuthorDate: 2025-08-02 17:57:44 +0000 Commit: Konstantin Belousov CommitDate: 2025-08-02 23:02:43 +0000 vfs_syscall.c: do not take process lock around the read of P2_NO_NEW_PRIVS The flag is write-only, and if we raced with reading the action of setting the flag, we can as well get it under the lock. Reviewed by: emaste, kevans Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D51708 --- sys/kern/vfs_syscalls.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index 25d40a9806cb..a0e56a8fd8a7 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -982,13 +982,10 @@ kern_chroot(struct thread *td, struct vnode *vp) error = priv_check(td, PRIV_VFS_CHROOT); if (error != 0) { p = td->td_proc; - PROC_LOCK(p); if (unprivileged_chroot == 0 || (p->p_flag2 & P2_NO_NEW_PRIVS) == 0) { - PROC_UNLOCK(p); goto e_vunlock; } - PROC_UNLOCK(p); } error = change_dir(vp, td);