From owner-svn-src-all@FreeBSD.ORG Sat Aug 10 19:27:56 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 47276FE3 for ; Sat, 10 Aug 2013 19:27:56 +0000 (UTC) (envelope-from peter@wemm.org) Received: from mail-vc0-x232.google.com (mail-vc0-x232.google.com [IPv6:2607:f8b0:400c:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 03C8B2C5C for ; Sat, 10 Aug 2013 19:27:55 +0000 (UTC) Received: by mail-vc0-f178.google.com with SMTP id ha12so1913679vcb.9 for ; Sat, 10 Aug 2013 12:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2UbIKMPH15MYk9/SNt0y79x0LVsTpXuLu/k18PAqJS4=; b=aqhKXzoNqltLVTnAr9iCN64HSX/Y30/tXmau0mHLOmIJMIQQFC7OhEj5RwzNBArJEr JCyCljFF5Yt9txb+Mj3onJ+xAG8lQVuzfUMXKG/kW1QhokVDG12tLCmHgN+9SYlIZlTC i/OrjGf4cXKScY6VBePcZgAbC9rUsXWjA6GjQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=2UbIKMPH15MYk9/SNt0y79x0LVsTpXuLu/k18PAqJS4=; b=ZqCWCw7Mdp7Ji0FnJTsVnA9QtYbZi/Ci4H2P6NFxBMU7F/wIM2H4yGRRu/9k4d0S6y Mo5bim8DqXLYT8LKTdvnPSOHHoW/q/MhKErS+4erzVs3TikGcHlLt9GoPEDyZWvfv0LP TBwDDh3odHgj4/maRt+Erx9R/keGCM6EdxFyDqjN6j55VCCAKcpmOh5iE/k98DZucgob /6eL859PnFAk1u9Zut0apvexugNBQ087KNqoRYHwRUf+198HEEUZNN3oQ7KpVKpjRCp8 6Ieuy+R60cA7Cv2XBhCU8OlSb4NukN/5dGObCVh0dcW1ecSv20bjNN3cVQ1w8kSr0Iui 0nqQ== X-Gm-Message-State: ALoCoQnSEPcLbs7yBtmOuvtfiKNpQbXSYBIXss51CmO1wonNtVUEsFKi2JyLN0h9vw+mbA1n7S1y MIME-Version: 1.0 X-Received: by 10.58.2.137 with SMTP id 9mr8845013veu.50.1376162874729; Sat, 10 Aug 2013 12:27:54 -0700 (PDT) Received: by 10.220.167.74 with HTTP; Sat, 10 Aug 2013 12:27:54 -0700 (PDT) In-Reply-To: <201308101823.r7AINS22019611@svn.freebsd.org> References: <201308101823.r7AINS22019611@svn.freebsd.org> Date: Sat, 10 Aug 2013 12:27:54 -0700 Message-ID: Subject: Re: svn commit: r254185 - head/sys/modules/random From: Peter Wemm To: Konstantin Belousov Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2013 19:27:56 -0000 On Sat, Aug 10, 2013 at 11:23 AM, Konstantin Belousov wrote: > Author: kib > Date: Sat Aug 10 18:23:28 2013 > New Revision: 254185 > URL: http://svnweb.freebsd.org/changeset/base/254185 > > Log: > Restore the ability to kldload random.ko, by linking in the newly > added random_adaptors.c. > > Modified: > head/sys/modules/random/Makefile > > Modified: head/sys/modules/random/Makefile > ============================================================================== > --- head/sys/modules/random/Makefile Sat Aug 10 18:23:18 2013 (r254184) > +++ head/sys/modules/random/Makefile Sat Aug 10 18:23:28 2013 (r254185) > @@ -5,7 +5,7 @@ > .PATH: ${.CURDIR}/../../crypto/sha2 > > KMOD= random > -SRCS= randomdev.c probe.c > +SRCS= randomdev.c random_adaptors.c probe.c > .if ${MACHINE} == "amd64" || ${MACHINE} == "i386" > SRCS+= nehemiah.c > SRCS+= ivy.c However, random_adapters.c is "standard": # grep random files dev/random/harvest.c standard dev/random/hash.c optional random dev/random/probe.c optional random dev/random/random_adaptors.c standard dev/random/randomdev.c optional random dev/random/randomdev_soft.c optional random dev/random/yarrow.c optional random I understand why harvest.c is standard - it's called by drivers. But wouldn't your change to the module above duplicate the module list into two separate namespaces? -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV UTF-8: for when a ' just won\342\200\231t do. ZFS must be the bacon of file systems. "everything's better with ZFS"