From owner-svn-src-head@freebsd.org Sat Nov 4 05:53:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4C8BE65F2D for ; Sat, 4 Nov 2017 05:53:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 787F421EA for ; Sat, 4 Nov 2017 05:53:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22f.google.com with SMTP id p186so10554380ioe.12 for ; Fri, 03 Nov 2017 22:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=BbRk6cbJEcpfyZqwyx6amlfacgknWSbGm3Q0f1zcVBo=; b=rD4pvVIwF6arNZB/HCBILAno1vvkQtMgLHxnN+JnyAdyMWXQPnd0HASj3XLBc9uBfH TaRuAQwxwhExROUNn4Tv3MEGZcyJzTzH03geSvlmkp92ysShMmsFn3kC8mnbfmHePOmJ 4Wbd30MLeFzO7rw8EcDSszW18zf4C88zVCf5OMw/R1iEWjFSpL9782IxFSJFauMv8MR3 vFIFxbrn7VPUYbQAHkM0NgIV79GGwvx/cxlwC04T6b9cECLm72GUrLYMneSgp87GkuzE jd3bfVWRXRNn8Su9qf7rnIp581k8joCdcAy07N+kEeunBXyhu0gp19BFs42emWUCRbL2 vBQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=BbRk6cbJEcpfyZqwyx6amlfacgknWSbGm3Q0f1zcVBo=; b=CCquiaWLvPzTGii1OL87ow3RJ2EmfNaldMh341GYXeqAeOI1RpD/2tSJh797y8rPJg iZ3fr9+QoKtr/02bvSaqGVNHjenW4irttVbm61IPf2c2cO15DOnV+Hzf4TlEZOqoIfYQ SDN0TjvAAg+aHzjDpr2mFNfU9+hHaiqmIBmqnAShG+Y+4wQLmmPDl2dvqwCv9+5aiBui Vti+dPWuCvCtqtGXVXJFROlsqLupc+yys7MpkcgKcziXU+JOWCaeHmXLwTHQ/s/VCJP5 CU/KyEQXaEhxm10SRBTgZ2UUf6K86W7/4XB5w3KtvJfUXFhCPUm4vXTjYVK3n/mAshaX xIXA== X-Gm-Message-State: AMCzsaVXhfIWF1gqNbR8GhY8xnWFOs5fhDR9/KOYUr7dLtnWkKYArO9+ 1ecqhRqzY9BbxjIxF+2ScyM5uhGZP8xmBuNnYEe3aA== X-Google-Smtp-Source: ABhQp+QD6/j8yJCN9ttGBwboBNHH6wbgTuFsbWRcu0+GzbBKEPk2lci9tJTJiXf2hi54bJ2MIH/c8jq9hytiqOjofmQ= X-Received: by 10.107.30.73 with SMTP id e70mr11588018ioe.130.1509774819756; Fri, 03 Nov 2017 22:53:39 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Fri, 3 Nov 2017 22:53:39 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:4daf:1291:4f1b:d2ea] In-Reply-To: <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> References: <201711040301.vA431wdY002757@repo.freebsd.org> <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> From: Warner Losh Date: Fri, 3 Nov 2017 23:53:39 -0600 X-Google-Sender-Auth: XgKeDYd6bpPQA9Nml_AXkigZNJg Message-ID: Subject: Re: svn commit: r325378 - head/sys/dev/ipmi To: Xin Li Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Xin LI Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 05:53:40 -0000 On Fri, Nov 3, 2017 at 11:29 PM, Xin Li wrote: > > > On 11/3/17 20:01, Warner Losh wrote: > > Author: imp > > Date: Sat Nov 4 03:01:58 2017 > > New Revision: 325378 > > URL: https://svnweb.freebsd.org/changeset/base/325378 > > > > Log: > > Make the startup timeout 0 seconds by default rathern than 420s. This > > makes the default fail safe when watchdogd is disabled (which is also > > the default). > > I'm not sure if this is good: what if watchdogd is enabled, but the > system get stuck before watchdogd starts? > Correct. This feature has to be opt-in on top of watchdogd. If you don't add-in this feature, you won't have this new protection. You have to set hw.ipmi.wd_startup_countdown to activate it. More complicated logic may be possible, but the ipmi driver has no clue if watchdogd is enabled, so I'm not sure I see a path forward to automatically doing the right thing with sensible defaults. Have I overlooked something? Warner