Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Aug 2018 02:09:10 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Wen Heping <wen@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r477768 - head/databases/p5-SQL-Abstract
Message-ID:  <CAMHz58S0fvSDdM=7R33e2LesPKQeGAjZz4tgMPpgELWYwDYJFA@mail.gmail.com>
In-Reply-To: <201808220341.w7M3fr65074802@repo.freebsd.org>
References:  <201808220341.w7M3fr65074802@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 22, 2018 at 11:42 AM Wen Heping <wen@freebsd.org> wrote:

> Author: wen
> Date: Wed Aug 22 03:41:52 2018
> New Revision: 477768
> URL: https://svnweb.freebsd.org/changeset/ports/477768
>
> Log:
>   - Add LICENSE_FILE_*
>   - Update DEPENDS
>
>   PR:           229695
>   Submitted by: svysh.fbsd@gmail.com
>
> Modified:
>   head/databases/p5-SQL-Abstract/Makefile
>
> Modified: head/databases/p5-SQL-Abstract/Makefile
>
> ==============================================================================
> --- head/databases/p5-SQL-Abstract/Makefile     Wed Aug 22 03:23:35 2018
>       (r477767)
> +++ head/databases/p5-SQL-Abstract/Makefile     Wed Aug 22 03:41:52 2018
>       (r477768)
> @@ -3,6 +3,7 @@
>
>  PORTNAME=      SQL-Abstract
>  PORTVERSION=   1.86
> +PORTREVISION=  1
>  CATEGORIES=    databases perl5
>  MASTER_SITES=  CPAN
>  PKGNAMEPREFIX= p5-
> @@ -12,13 +13,17 @@ COMMENT=    Perl extension to generate SQL from Perl
> data
>
>  LICENSE=       ART10 GPLv1+
>  LICENSE_COMB=  dual
> +LICENSE_FILE_ART=      ${WRKDIR}/LICENSE
> +LICENSE_FILE_GPL=      ${WRKDIR}/LICENSE
>

Hi,

IIUC, both knobs do not exist.
I guess you mean LICENSE_FILE_ART10 and LICENSE_FILE_GPLv1+.
And that could be simplified as "LICENSE_FILE=${WRKSRC}/LICENSE".


>  BUILD_DEPENDS= p5-Hash-Merge>=0.12:textproc/p5-Hash-Merge \
>                 p5-Moo>=2.000001:devel/p5-Moo \
> +               p5-MRO-Compat>=0.12:devel/p5-MRO-Compat \
>

That is not needed for perl ports.

from lib/SQL/Abstract.pm:
  if ($] < 5.009_005) {
    require MRO::Compat;
  }
  else {
    require mro;
  }

                p5-Sub-Quote>=2.000001:devel/p5-Sub-Quote \
>                 p5-Test-Deep>=0.101:devel/p5-Test-Deep
>  RUN_DEPENDS:=  ${BUILD_DEPENDS}
> -TEST_DEPENDS=  p5-Test-Exception>=0.31:devel/p5-Test-Exception \
> +TEST_DEPENDS=  p5-DBIx-Class>=0:databases/p5-DBIx-Class \
> +               p5-Test-Exception>=0.31:devel/p5-Test-Exception \
>                 p5-Test-Warn>=0:devel/p5-Test-Warn
>
>  NO_ARCH=       yes
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58S0fvSDdM=7R33e2LesPKQeGAjZz4tgMPpgELWYwDYJFA>