Date: Tue, 14 Jul 2015 12:09:38 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Matthew D. Fuller" <fullermd@over-yonder.net> Cc: RW <rwmaillists@googlemail.com>, freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150714100936.GA1239@garage.freebsd.pl> In-Reply-To: <20150714064212.GZ96394@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> <20150629013841.GO50491@over-yonder.net> <20150710200055.GB1270@garage.freebsd.pl> <20150710222837.GE96394@over-yonder.net> <20150711141553.3fcf91f4@gumby.homeunix.com> <20150713153146.GA1984@garage.freebsd.pl> <20150714064212.GZ96394@over-yonder.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2015 at 01:42:12AM -0500, Matthew D. Fuller wrote: > On Mon, Jul 13, 2015 at 05:31:46PM +0200 I heard the voice of > Pawel Jakub Dawidek, and lo! it spake thus: > >=20 > > So what do you guys think about implementing trim support this way: > >=20 > > geli -d <trim|overwrite|ignore> > >=20 > > 'overwrite' may be implemented later and 'trim' would be the default? >=20 > Well, if you ask me, we can work out the UI for a 3-way choice when a > third way is implemented. Doing shredding would presumably be noted > by adding another flag[0] for it anyway, so doing it on top of this > patch oughtn't take it out of its way. Nobody's implemented it in the > last 10 years that there's been a comment suggesting it. >=20 > So, from my selfish perspective, I'd as soon land this as a solid step > forward, and worry about a shredding implementation when one gets > written... >=20 >=20 > [0] I mean, I _guess_ we could add another element into the > metadata/softc structs just to hold a 3-way 'delete handling' > option, but that sounds way heavier-weight than necessary. Also > would need new geli version and blah. I wanted to avoid changing command line arguments in the future for people who automate GELI creation, but you know what, I just realized that TRIM/UNMAP and overwrite are not mutually exclusive. I may want to overwrite first and then do the TRIM. If those two are not mutually exclusive then, finally, I think your patch is fine! Thank you for your patience and expect the commit soon:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVpN/gAAoJEJVLhSuxKFt1pMgP/jkyhKxgglwGbW7YdoZ8rq9K RKqqME/v/HMbQr2PIJula2e4gdNsXvPAqUI65B7VS09rDhY+1k1aDD2Kz3DAuEaC 2gQ5o/OH0R02z4Gki0iZr6Gq9Dtpn0q3g4VDLsX507F45Erbpw9pss654ye5uxhi 0aXaZFMWaeC9gl9FjqHFnXHb8zOE03EX4C6S4XOFcrfI9CoJTO9nFvzZjwNoEiYx pQHA6Iv4wYCSsOVKD7QWrHGetOs8pFaKiR9T/x+peB2IKdjmpKfa9jt5Iz8tM8Ho SdkVSRxs0jqF5+TfrBloeJOlK2BCMP3tYPSNrqahZGvJw8VMCQ/XPzuHUYKlXQGt +QoCXLKXwOZwjlnDOvJr23jFRBLIuUQrQ2g6FkTDKGUBh2DtfFbfttEGJJ7uuRdk o2fhGyPd0qz1Mo7FiSMJrSSupg6Dvtk9Z5kcQs1nhcQf5q9Fjl3vRW3KLGTHfWN7 8x6iaC/6eQy4X9Zn/QkjprtG9DkqTCFtfHVzq3RAeGfnJFyco5RRRI1zQuMdqJj/ QR7ajk/r42szvYFT74uOxCPWCENOs3jm5yTsUxOgewdhmYlJuYLZyiEMoXPtIenI +0AFWxyQqPQFz0/OsEop+gkFQG+VjXKycf8Zi1B6wHgIKh5DNFP+baS/YWSDEsFL sT7BW1R6hpIa92XlZScM =pZJq -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150714100936.GA1239>