From owner-svn-src-all@freebsd.org Sat Aug 31 00:45:02 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 586BADC887; Sat, 31 Aug 2019 00:45:02 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46KyL56XQpz3Fky; Sat, 31 Aug 2019 00:45:01 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 3rVgiYr3ISrVc3rVhi3G37; Fri, 30 Aug 2019 18:44:59 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=FmdZ9Uzk2mMA:10 a=6I5d2MoRAAAA:8 a=ypVJL4-jAAAA:8 a=YxBL1-UpAAAA:8 a=KWaSwiQ3T9b_v806dOsA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 a=khIbc0fXALFIcTpOSxgJ:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from [IPv6:2605:8d80:403:7c6b:45f7:b036:707d:4d1f] (unknown [72.143.236.68]) by spqr.komquats.com (Postfix) with ESMTPSA id 268CB97A; Fri, 30 Aug 2019 17:44:55 -0700 (PDT) Date: Fri, 30 Aug 2019 17:44:26 -0700 In-Reply-To: <6035df87490ebb7429f76d57a3a5d33e86c06b56.camel@freebsd.org> References: <201908250511.x7P5BiPl016074@repo.freebsd.org> <6035df87490ebb7429f76d57a3a5d33e86c06b56.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r351471 - in head/sys: kern sys To: Ian Lepore , Mateusz Guzik , Oliver Pinter CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Cy Schubert Message-ID: X-CMAE-Envelope: MS4wfFQXh4OD9+nXTHXvrSfxvAArtUAegC3sJuW4rhoGKUvZqxJzgy6ctoP3i3g0shM/BDv45mqu+5Gl73azHOl7UUnCOtBjD4fDGMae0H0cV1L4xCKpd6jQ ltzCNdUwmJa7sBaX8h+fryxlOmnsMAaEhgBZyObgx2pwUtmrOsTBk0W338mzpDK3Wn6s3NWQ0zHHXmCd5n76BEe+UTG7KHsm4ty45XjANQSKs3V3F1PWEUBz HzYStXkbseRDY4K/fv1wOm7VeoU610d/ZqFiUvVnbp+WMrqh53txNrAAJnmg5v6987zsm7lE1yW2uwjVer93SeffG629HXvMDK1Bw+RRsXY= X-Rspamd-Queue-Id: 46KyL56XQpz3Fky X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.93)[-0.929,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Aug 2019 00:45:02 -0000 On August 30, 2019 3:09:06 PM PDT, Ian Lepore wrote: >On Sat, 2019-08-31 at 00:03 +0200, Mateusz Guzik wrote: >> On 8/25/19, Oliver Pinter wrote: >> > On Sunday, August 25, 2019, Mateusz Guzik wrote: >> >=20 >> > > Author: mjg >> > > Date: Sun Aug 25 05:11:43 2019 >> > > New Revision: 351471 >> > > URL: https://svnweb=2Efreebsd=2Eorg/changeset/base/351471 >> > >=20 >> > > Log: >> > > vfs: add vholdnz (for already held vnodes) >> >=20 >> >=20 >> > Why? >> >=20 >> > (Yes, is can read the real reason in phabricator, but the >> > phabricator >> > didn't considered a persistent information in relation to commit >> > message=2E >> > Review helper tool just comes and goes as time goes forward, but >> > commit >> > messages survives the repo conversions to other VCS=2E=2E=2E) >> >=20 >> > And once you have taken the time to write a correct description in >> > phabricator, it would be really really nice and helpful if you >> > would copy >> > them into commit message=2E >> >=20 >>=20 >> I think it's a fair point that if I included this info in the review >> it >> should make it's way into the commit message=2E >>=20 > >When I open a new phab review, I specifically write the one-line >summary and text that follows with the idea that I'm going to cut and >paste that exact text as the commit message (mostly because it's easier >to just write all that stuff once)=2E If there are things I want to say >there that don't make sense for the commit I typically add them as a >separate comment right after I open the initial review=2E > >-- Ian I like to start out with a one line summary if possible, subsequently prov= iding more detail=2E The first paragraph or two of a phab review could/should be written to sim= ply cut and paste that into the commit message=2E I try to aim for this=2E I suppose when a person has been working on some code for a while what app= ears obvious may not be so obvious to others at first=2E It's an easy trap = to fall into=2E Something I catch myself at times=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E