From owner-cvs-all Sat Dec 18 9:38:44 1999 Delivered-To: cvs-all@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id AF6F414E74; Sat, 18 Dec 1999 09:38:33 -0800 (PST) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost [127.0.0.1]) by green.dyndns.org (8.9.3/8.9.3) with ESMTP id MAA76337; Sat, 18 Dec 1999 12:38:03 -0500 (EST) (envelope-from green@FreeBSD.org) Date: Sat, 18 Dec 1999 12:38:03 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Warner Losh Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen fts.c In-Reply-To: <199912181655.JAA91056@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sat, 18 Dec 1999, Warner Losh wrote: > In message Brian Fundakowski Feldman writes: > : What do you object to? In my analysis of the changes, I didn't notice > : anything bad. The only difference I can think of objecting to would > : be reversion to using realloc() instead of reallocf(), but the code > : works the same either way. > > Using realloc instead of reallocf introduces a memory leak when the > system can't realloc the memory. They use realloc() and explicit freeing. > > Warner > -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message