From owner-svn-src-all@FreeBSD.ORG Fri Sep 14 13:38:47 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07C66106564A; Fri, 14 Sep 2012 13:38:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 6FD068FC1A; Fri, 14 Sep 2012 13:38:45 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q8EDcjBa025153; Fri, 14 Sep 2012 16:38:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q8EDcXYX002313; Fri, 14 Sep 2012 16:38:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q8EDcX93002310; Fri, 14 Sep 2012 16:38:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 14 Sep 2012 16:38:33 +0300 From: Konstantin Belousov To: Attilio Rao Message-ID: <20120914133833.GC37286@deviant.kiev.zoral.com.ua> References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TMTfqzsZeEKgETVO" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2012 13:38:47 -0000 --TMTfqzsZeEKgETVO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 14, 2012 at 01:03:13PM +0100, Attilio Rao wrote: > On 9/14/12, Konstantin Belousov wrote: > > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: > >> Author: attilio > >> Date: Thu Sep 13 22:26:22 2012 > >> New Revision: 240475 > >> URL: http://svn.freebsd.org/changeset/base/240475 > >> > >> Log: > >> Remove all the checks on curthread !=3D NULL with the exception of s= ome > >> MD > >> trap checks (eg. printtrap()). > >> > >> Generally this check is not needed anymore, as there is not a > >> legitimate > >> case where curthread !=3D NULL, after pcpu 0 area has been properly > >> initialized. > > I do not disagree with the patch, but I do with this statement. > > During the AP startup, there is indeed a window while curthread is NULL. > > Unfortunately, trying to panic there is worse then not panic. >=20 > Yes and why do you disagree then? That is what I wanted to say -- > before pcpu->curthread is initialized you can get curthread =3D=3D NULL. I disagree with the statement that curthread is always non-NULL after pcpu 0 area has been initialized. --TMTfqzsZeEKgETVO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBTM1gACgkQC3+MBN1Mb4jF1wCdFDrXzcny07Lv2ljv8wu0/LK7 lC8AoPHuRtgUxQl4FzsXApM1SArPI40e =wrcl -----END PGP SIGNATURE----- --TMTfqzsZeEKgETVO--