Date: Fri, 14 Sep 2012 16:38:33 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Attilio Rao <attilio@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240475 - in head/sys: dev/hwpmc kern Message-ID: <20120914133833.GC37286@deviant.kiev.zoral.com.ua> In-Reply-To: <CAJ-FndCHqpnLpaf12ASdnEtcY%2BP%2BBw-hb6zKz7MQrRHJf4kVBw@mail.gmail.com> References: <201209132226.q8DMQMFC088169@svn.freebsd.org> <20120914042031.GZ37286@deviant.kiev.zoral.com.ua> <CAJ-FndCHqpnLpaf12ASdnEtcY%2BP%2BBw-hb6zKz7MQrRHJf4kVBw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--TMTfqzsZeEKgETVO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 14, 2012 at 01:03:13PM +0100, Attilio Rao wrote: > On 9/14/12, Konstantin Belousov <kostikbel@gmail.com> wrote: > > On Thu, Sep 13, 2012 at 10:26:22PM +0000, Attilio Rao wrote: > >> Author: attilio > >> Date: Thu Sep 13 22:26:22 2012 > >> New Revision: 240475 > >> URL: http://svn.freebsd.org/changeset/base/240475 > >> > >> Log: > >> Remove all the checks on curthread !=3D NULL with the exception of s= ome > >> MD > >> trap checks (eg. printtrap()). > >> > >> Generally this check is not needed anymore, as there is not a > >> legitimate > >> case where curthread !=3D NULL, after pcpu 0 area has been properly > >> initialized. > > I do not disagree with the patch, but I do with this statement. > > During the AP startup, there is indeed a window while curthread is NULL. > > Unfortunately, trying to panic there is worse then not panic. >=20 > Yes and why do you disagree then? That is what I wanted to say -- > before pcpu->curthread is initialized you can get curthread =3D=3D NULL. I disagree with the statement that curthread is always non-NULL after pcpu 0 area has been initialized. --TMTfqzsZeEKgETVO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlBTM1gACgkQC3+MBN1Mb4jF1wCdFDrXzcny07Lv2ljv8wu0/LK7 lC8AoPHuRtgUxQl4FzsXApM1SArPI40e =wrcl -----END PGP SIGNATURE----- --TMTfqzsZeEKgETVO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120914133833.GC37286>