From owner-svn-src-all@freebsd.org Fri Aug 25 18:02:45 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52E7BDDDC90; Fri, 25 Aug 2017 18:02:45 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-qt0-x22d.google.com (mail-qt0-x22d.google.com [IPv6:2607:f8b0:400d:c0d::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 09D3569E32; Fri, 25 Aug 2017 18:02:45 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-qt0-x22d.google.com with SMTP id q53so2604228qtq.5; Fri, 25 Aug 2017 11:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=CVfiyVOv6LAMqc7XQWSS06hm5VkS8zG5pttzQsI5xJQ=; b=EwzNzBtuhIvY0WO2kEOn3YREUNT2BSUbVAY91VtmkiDyRAR0h0GsteYyAqfkn8BQe6 w/yQi6IRAQ9bqbloY6km4wagtzF5t3FmYycT8suHNM+92gDmyNIEh2JGkhANTyiTBTEf 9Re03aGMS1xKbDKq1Our5UqIywsiuc8jYU+MMlynNZYbCceGuIYEDcnWKm5BWlIqcLif PBOxcJJ8FqF0IyN0VDq8aHxY93l6VcWMjVJkXHDDPy+PNTQZVU32SNooc/3QfI0/XEnJ +6pT0MLYc/9w/wRWy3c35UMWuwhWWBCn4E/15LLEe+oTJOdnW3hqDgncsOCtYfSZfo1i BDlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CVfiyVOv6LAMqc7XQWSS06hm5VkS8zG5pttzQsI5xJQ=; b=uiAu97Lx7TwiEFafRDAk5iTgm4iIVcQELB4Y3eUdQYF4wsQX3KUQ2Qz25JD0/vdosv UE41Qpda+WAJYoQSdtpl7h21Gje/1kPj23hchibPabRWkQd9N59nY/8rGcLg5HiVWT6Z cuJjyjpPhJLhMPRtAFM+qeBK6Nm/pjxnLW+N6sw3NRmy1EmOeCl+dpswunWh1ojyYwxE 6GEbncvScf3i4Dv9uOsT+oiSTmXMxhCbD8FKK+q8wTCFE7dswAEvRifBR5vfT+64hg6q J1m4FapU2BONEfhFDsT/hYXwbkF+i5kLqyPMtAS9m04H2QbBHcUnGXpWb3OQyURf7M6W rkBQ== X-Gm-Message-State: AHYfb5h2nafaze8IVZYn6VuFSAT8jSyif/qxVIp7q0yrZ/CpNtbZBhYv SSA+7727YQbARLaoelo= X-Received: by 10.200.22.57 with SMTP id p54mr16012390qtj.317.1503684163763; Fri, 25 Aug 2017 11:02:43 -0700 (PDT) Received: from [192.168.2.122] (71-212-20-168.tukw.qwest.net. [71.212.20.168]) by smtp.gmail.com with ESMTPSA id 22sm4488107qto.36.2017.08.25.11.02.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Aug 2017 11:02:41 -0700 (PDT) Subject: Re: svn commit: r322893 - head/bin/dd To: cem@freebsd.org, Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201708251531.v7PFVtoZ038242@repo.freebsd.org> From: Matt Joras Message-ID: <4b016f89-61c5-fc8a-a36a-aca8166c369e@gmail.com> Date: Fri, 25 Aug 2017 11:02:40 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 18:02:45 -0000 On 08/25/2017 10:17, Conrad Meyer wrote: > This change seems to break buildworld on MIPS: > > /home/cem/head.svn/bin/dd/args.c: In function 'f_bs': > /home/cem/head.svn/bin/dd/args.c:188: warning: format '%zd' expects > type 'signed size_t', but argument 3 has type 'long int' > /home/cem/head.svn/bin/dd/args.c: In function 'f_cbs': > /home/cem/head.svn/bin/dd/args.c:199: warning: format '%zd' expects > type 'signed size_t', but argument 3 has type 'long int' > /home/cem/head.svn/bin/dd/args.c: In function 'f_ibs': > /home/cem/head.svn/bin/dd/args.c:245: warning: format '%zd' expects > type 'signed size_t', but argument 3 has type 'long int' > /home/cem/head.svn/bin/dd/args.c: In function 'f_obs': > /home/cem/head.svn/bin/dd/args.c:266: warning: format '%zd' expects > type 'signed size_t', but argument 3 has type 'long int' > > (Yes, it's odd that the SSIZE_MAX constant has 'long' type.) > SSIZE_MAX should have type long, since ssize_t is a long on mips (and other arches besides i386 and arm). Re: the build failure, that's in the GCC C format string checking, so perhaps it's more accurate to say this breaks the (in-tree) GCC build. %zd is the right format specifier for ssize_t. I guess GCC's format string checking is getting confused because SSIZE_MAX is a constant that expands to type long. Perhaps casting to ssize_t would GCC happier, but that looks rather wrong. Matt