Date: Tue, 21 Jan 2025 19:22:13 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Charlie Li <vishwin@freebsd.org> Cc: Vladimir Druzenko <vvd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e94a554e5542 - main - net/libproxy: bump consumers Message-ID: <gjqhy5vhpkorknygndy6wtd7oxefxcczg2lfmwbojwc2f3furu@hthxpthum7dx> In-Reply-To: <d2640284-9bc4-4e2b-b09e-d95ec9caf863@freebsd.org> References: <202501200502.50K52FZ0040498@gitrepo.freebsd.org> <365f4bcd-67c6-406a-ab09-c183760ee2b4@freebsd.org> <1e338faa-706a-4ce2-820a-6da9df0b40d3@freebsd.org> <e66z62oggyzvcpenl44cywyuzs5l7j3yrngnayeagiza7nqyr7@msppojfwx5wr> <d2640284-9bc4-4e2b-b09e-d95ec9caf863@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--awj7mhxogq6ukeqv Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: e94a554e5542 - main - net/libproxy: bump consumers MIME-Version: 1.0 Le Tue, Jan 21, 2025 at 02:03:18AM -0500, Charlie Li a =E9crit : > Mathieu Arnold wrote: > > Le Mon, Jan 20, 2025 at 09:39:58AM -0500, Charlie Li a =E9crit : > > > LIBPROXY is not enabled by default in any of the gecko@ ports. > >=20 > > I don't see how this is relevant. > > On shared library change, you bump a port if it has a dependency to the > > library in question, wether that dependency is optional or not has > > nothing to do with it. > >=20 > It is absolutely relevant when the resulting package content does not cha= nge > because it never linked to the bumped library in the first place. If the > option with the bumped library was enabled by default, the generated pack= age > content would change, thus PORTREVISION bump in such case. I don't rememb= er > any previous cases where PORTREVISIONs were bumped when the package conte= nts > don't change on a default disabled option. Well, for people who enabled the optionm the resulting package definitively is linked with the library, and is broken. The ports tree is not only for people using the official packages, you need to account for every users, thus bump ports depending on a library, wether it is a default dependency or not. --=20 Mathieu Arnold --awj7mhxogq6ukeqv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmeP5dJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb7XUAv/fijLH4GKirHoPi5MtE75nvtHWMNyGumI1Ow7fS+xFVOMdrznI3a8dHVm 04nCKa+cWBUOHOgVe0aj3y7WFDwWWdR/HfezSCRrH0DBz3jAXfcrMDWk3DZyno5e XrEzAU8BzzL1JQNIRpUsQEQW/gfDYlRC8daf+6OrlifIuZBheiKIBiTw4FKkY4dQ E6gMaBFbylbu2FWLBgcfMbrJbXlxVEF17qMk4H49mt6t2rOxhjbykwXQUyt2oEdv 93I8Rt5xFatdTk7yhBydxpgEgHh5pQNx7GeE0K5bVHz5vDgvvYfaJ+lqEMF6bJMB cVklzuS5m2anhuLYJCS71rVTKp9Ti1BRqxNuOTOTHAIe6Mib/8Ot1fkFkLa/IDLb FSwlDV1K1bIyrXDIhWwHcVyvY8jfJ0F+atJ4v6pVSUzBkYXgqjdP/GeddKzkpuhq tLt3GopMfuqRd2KCtxkyoAmvLKP2vrQhA0elMQ9UK/Hd0LZwtYHLiQRC19e0aQXC LIAeNdRE =97Dv -----END PGP SIGNATURE----- --awj7mhxogq6ukeqv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?gjqhy5vhpkorknygndy6wtd7oxefxcczg2lfmwbojwc2f3furu>