From owner-cvs-src@FreeBSD.ORG Tue Jun 3 14:52:28 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AA081065682; Tue, 3 Jun 2008 14:52:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id A3AD78FC12; Tue, 3 Jun 2008 14:52:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m53Eq8ZU073301; Tue, 3 Jun 2008 10:52:20 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Coleman Kane Date: Tue, 3 Jun 2008 10:04:43 -0400 User-Agent: KMail/1.9.7 References: <200806030055.m530tqVF044140@repoman.freebsd.org> In-Reply-To: <200806030055.m530tqVF044140@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806031004.43883.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 03 Jun 2008 10:52:20 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7340/Tue Jun 3 08:03:22 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/if_ndis if_ndis.c if_ndisvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jun 2008 14:52:28 -0000 On Monday 02 June 2008 08:55:48 pm Coleman Kane wrote: > cokane 2008-06-03 00:55:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/if_ndis if_ndis.c if_ndisvar.h > Log: > SVN rev 179498 on 2008-06-03 00:55:48Z by cokane > > Update if_ndis to remove the legacy if_watchdog interface and > bring it more up to date. The watchdog timer, and its > associated code, is all collapsed into the ndis_tick function > that was implemented for the NDIS-subsystem watchdog. This > implementation is similar to what numerous other drivers use > to implement the watchdog. > > Reviewed by: thompsa, jhb > MFC after: 2 weeks You should make the callout routine use callout_init_mtx() instead as it is less race-prone. -- John Baldwin