From owner-freebsd-bugs@freebsd.org  Tue Mar  8 02:35:43 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E6B0AC26AB
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Tue,  8 Mar 2016 02:35:43 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1745C8F8
 for <freebsd-bugs@FreeBSD.org>; Tue,  8 Mar 2016 02:35:43 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u282Zg6i047901
 for <freebsd-bugs@FreeBSD.org>; Tue, 8 Mar 2016 02:35:42 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 207786] gpioiic_callback() dereferences IIC "how" argument
 incorrectly
Date: Tue, 08 Mar 2016 02:35:43 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: chadf@triularity.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 attachments.created
Message-ID: <bug-207786-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 02:35:43 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207786

            Bug ID: 207786
           Summary: gpioiic_callback() dereferences IIC "how" argument
                    incorrectly
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: chadf@triularity.org

Created attachment 167825
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D167825&action=
=3Dedit
Patch file for sys/dev/gpio/gpioiic.c

Instead of casting the "data" parameter to an int pointer and dereferencing=
, it
dereferences the caddr_t (a char *) and then casts that value to an int.
Currently, on little-endian systems it happens to work as expected, but is
broken for other hardware.

gpioiic_callback(device_t dev, int index, caddr_t data)
{
        struct gpioiic_softc    *sc =3D device_get_softc(dev);
        int error, how;

        how =3D GPIOBUS_DONTWAIT;
        if (data !=3D NULL && (int)*data =3D=3D IIC_WAIT)
                how =3D GPIOBUS_WAIT;
        error =3D 0;
        switch (index) {
        case IIC_REQUEST_BUS:
                error =3D GPIOBUS_ACQUIRE_BUS(sc->sc_busdev, sc->sc_dev, ho=
w);
                break;

Patch file included.

Side note: To increase efficiency, it could be changed to an if/else settin=
g of
"how" and moved into the IIC_REQUEST_BUS switch entry, as only that code us=
es
it.

--=20
You are receiving this mail because:
You are the assignee for the bug.=