From owner-svn-src-all@freebsd.org Sat Oct 31 21:56:46 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5E10457541 for ; Sat, 31 Oct 2020 21:56:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNtLP6MQKz425M for ; Sat, 31 Oct 2020 21:56:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id z6so8352420qkz.4 for ; Sat, 31 Oct 2020 14:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sqAC1Qdcint626ftdfojnoAP2NTKomlvdtvgoNwulSA=; b=teAqngGSDeP0ev4vw35bZwYSPrPi3pxKurNyDmKeGpD5mk1ISOpJISex9akN5U1VhP hNFIMEx17J7bIRG8hJlgfuSAIE+Ja+9SvoxepPBOhWxUbeL+S2Mb6Bk/u+yYYTVHXd84 43YmjGAgeDtNv07PynsF7MhYC636XyQiiJNahBsNXt0CM9niPG+qASijhgHJ6DaylvDK ephRP94/Kw0o75Hl1kofyonY0NghCCFgC8TL7+lcfeRN3XzYtBPkjcvt07Hh9jI8Q4sq 1QPjNL7H5Pe7CN477aGWOusvoaQmr86+XoRhF08hjvGHdXWspvJV3GnEeTdB7vjCVrSv q3rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sqAC1Qdcint626ftdfojnoAP2NTKomlvdtvgoNwulSA=; b=dOtDWpKfPcxX4fKLEygoGjtt25ifg2L7TdrgzztsrVF6L59sD0o0hf5QCbS1ovUpnn NGib9YXYGrZgZfU9KjEk1LrGLsGrl9uPdjxNaDEPsGGIcT3bbcAIVF1IRgPHgonsLktV cJVAHAReIzYtAOjy4YXc4XNal41fZI04zObwUgPN+BY3c/kzzZ4rdlto38lWix7t9kk2 JJI2j5TgLmRtfDbFWI7eouC8CmKT9czjAIsT0UNl0sG9oLLb76/SeNxqrMDaxsmC3xyS mlsB6khSREkKYDCrtZOP12c39fQQOWgk8ObJUI8lrTg1SR8dWG9LYFFPXegLhV/vZ7ex 4o+A== X-Gm-Message-State: AOAM531MlstBqwtJvkucZOIqGmbmeQIY+tM9mOdnjgY8DB13UAk4ends KVugVe8Bkgsz6bjES4PtZa5BzhbN+PqZkFpxjJ/7AQ== X-Google-Smtp-Source: ABdhPJxZWmcYnjzbrrgiMUecD1Jg6PWD7ToCzH9s43sddQyWIHjvCPHQCnJ3mvOnIsIrtwiYaOcEfwnONGDNS+vdCEo= X-Received: by 2002:a05:620a:15cc:: with SMTP id o12mr8606561qkm.356.1604181404605; Sat, 31 Oct 2020 14:56:44 -0700 (PDT) MIME-Version: 1.0 References: <202010311907.09VJ7WcY036325@repo.freebsd.org> <7b9e157c-9b8e-4a0e-b3f6-38edbfebf005@www.fastmail.com> <540675c8-35bb-40a7-b947-73f31a72bff2@www.fastmail.com> In-Reply-To: From: Warner Losh Date: Sat, 31 Oct 2020 15:56:33 -0600 Message-ID: Subject: Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd To: Mateusz Guzik Cc: Brandon Bergren , Brandon Bergren , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 4CNtLP6MQKz425M X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=teAqngGS; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.91 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.83)[-0.835]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-0.98)[-0.980]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.10)[-0.096]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72e:from]; R_SPF_NA(0.00)[no SPF record]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-all]; FREEMAIL_CC(0.00)[freebsd.org,imap.cc] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 21:56:47 -0000 Go for it. Warner On Sat, Oct 31, 2020, 2:57 PM Mateusz Guzik wrote: > I agree. Please commit. > > On 10/31/20, Brandon Bergren wrote: > > Yeah, that is what was happening. The minimal implementation needed for > > libsa was missing. > > > > On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren wrote: > >> Maybe this is it?: > >> > >> Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h > >> =================================================================== > >> --- sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (revision > >> 367230) > >> +++ sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (working > >> copy) > >> @@ -188,6 +188,8 @@ > >> */ > >> #undef atomic_add_64 > >> #define atomic_add_64(ptr, val) *(ptr) += val > >> +#undef atomic_sub_64 > >> +#define atomic_sub_64(ptr, val) *(ptr) -= val > >> #endif /* !_STANDALONE */ > >> > >> #endif /* !_OPENSOLARIS_SYS_ATOMIC_H_ */ > >> > >> > >> Note that there is also another build failure in the tree at the moment. > >> > >> On Sat, Oct 31, 2020, at 3:25 PM, Brandon Bergren wrote: > >> > Actually, looking at it again, it looks like the spl header is doing > it > >> > > >> > wrong and not providing a fallback for atomic_sub_64, it's just > >> > defining it to atomic_subtract_64 and assuming that exists. > >> > > >> > On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: > >> > > Yep, jenkins told me. Working on it. > >> > > > >> > > On 10/31/20, Brandon Bergren wrote: > >> > > > This doesn't compile on platforms such as powerpc without pulling > in > >> > > > the > >> > > > opensolaris atomics header from the spl that does locking > emulation > >> > > > of 64 > >> > > > bit atomics, as platforms that don't have native 64 bit atomics do > >> > > > not > >> > > > provide them in the system header. > >> > > >> > >> -- > >> Brandon Bergren > >> bdragon@imap.cc > >> > > > > -- > > Brandon Bergren > > bdragon@FreeBSD.org > > > > > -- > Mateusz Guzik >