From owner-dev-commits-src-all@freebsd.org  Sat May 15 22:44:57 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70C81629F23;
 Sat, 15 May 2021 22:44:57 +0000 (UTC)
 (envelope-from lutz@iks-jena.de)
Received: from annwfn.iks-jena.de (annwfn.iks-jena.de [IPv6:2001:4bd8::19])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FjL7Y1N9Qz4ZPH;
 Sat, 15 May 2021 22:44:56 +0000 (UTC)
 (envelope-from lutz@iks-jena.de)
X-SMTP-Sender: IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f
Received: from belenus.iks-jena.de (belenus.iks-jena.de
 [IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f])
 by annwfn.iks-jena.de (8.15.2/8.15.2) with ESMTPS id 14FMiseA023622
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
 Sun, 16 May 2021 00:44:54 +0200
X-MSA-Host: belenus.iks-jena.de
Received: (from lutz@localhost)
 by belenus.iks-jena.de (8.14.3/8.14.1/Submit) id 14FMisfL024199;
 Sun, 16 May 2021 00:44:54 +0200
Date: Sun, 16 May 2021 00:44:54 +0200
From: Lutz Donnerhacke <lutz@donnerhacke.de>
To: Jessica Clarke <jrtc27@freebsd.org>
Cc: Konstantin Belousov <kostikbel@gmail.com>,
 Lutz Donnerhacke <donner@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup
Message-ID: <20210515224454.GB21814@belenus.iks-jena.de>
References: <202105150701.14F717lf084359@gitrepo.freebsd.org>
 <YKAkAcYHXN7XMyoL@kib.kiev.ua> <20210515195812.GB17734@belenus.iks-jena.de>
 <YKArpyRTTAah4LSG@kib.kiev.ua> <20210515205133.GA19770@belenus.iks-jena.de>
 <YKA9jrWPkeCUgwPf@kib.kiev.ua> <20210515223634.GA21814@belenus.iks-jena.de>
 <67F972DE-A735-4537-8AFB-87E4E9832424@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <67F972DE-A735-4537-8AFB-87E4E9832424@freebsd.org>
X-message-flag: Please send plain text messages only. Thank you.
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Rspamd-Queue-Id: 4FjL7Y1N9Qz4ZPH
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 May 2021 22:44:57 -0000

On Sat, May 15, 2021 at 11:42:06PM +0100, Jessica Clarke wrote:
> I think you two are talking past each other. kib@’s point is that some of the
> changes made in this commit were style *changes* not style *fixes* (i.e. the
> code was compliant before, you’ve just changed it from one acceptable
> formatting to another), and that there were instances of significant style
> violations *not* fixed (e.g. the assertion macro before variable declarations
> pointed out). He is not talking about functional violations, only style ones.
> However, in your defence, your original commit did not claim to fix *all* style
> violations, only "most annoying style errors", though that doesn’t account for
> unnecessary churn as seen with the blank lines at the starts of functions.

You are right. Let's close this discussion.