From owner-cvs-sys Fri May 22 02:15:53 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA13473 for cvs-sys-outgoing; Fri, 22 May 1998 02:15:53 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from firewall.reed.wattle.id.au (darren2.lnk.telstra.net [139.130.53.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA13421; Fri, 22 May 1998 02:15:32 -0700 (PDT) (envelope-from darrenr@reed.wattle.id.au) Received: (from root@localhost) by firewall.reed.wattle.id.au (8.8.7/8.8.7) id JAA17833; Fri, 22 May 1998 09:15:34 GMT Received: from avalon.reed.wattle.id.au(192.168.1.1) by firewall.reed.wattle.id.au via smap (V1.3) id sma017831; Fri May 22 09:15:33 1998 Received: from percival.reed.wattle.id.au. (percival.reed.wattle.id.au [192.168.1.5]) by avalon.reed.wattle.id.au (8.9.0.Beta3/8.9.0.Beta3) with SMTP id TAA13747; Fri, 22 May 1998 19:15:08 +1000 (EST) From: Darren Reed Message-Id: <199805220915.TAA13747@avalon.reed.wattle.id.au> Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h In-Reply-To: <199805220605.QAA06912@godzilla.zeta.org.au> from Bruce Evans at "May 22, 98 04:05:51 pm" To: bde@zeta.org.au (Bruce Evans) Date: Fri, 22 May 1998 19:14:55 +1000 (EST) Cc: bde@zeta.org.au, jkh@time.cdrom.com, cvs-all@freebsd.org, cvs-committers@freebsd.org, cvs-sys@freebsd.org X-Mailer: ELM [version 2.4ME+ PL37 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@freebsd.org X-Loop: FreeBSD.org Precedence: bulk In some email I received from Bruce Evans, sie wrote: > >> That may be so, but when the sources are committed to the tree proper, > >> they shouldn't have ifdef version spaghetti. > > > >Hmmm. Just to be sure I understand your position - are you saying > >that sources should never use conditional compilation which depends > >on the FreeBSD version number? That seems... Draconian. > > Yes. Nothing like making life hard for people developing non-core applications for FreeBSD developers who (for one reason or another) are required to support multiple versions of the OS in the source. However, FreeBSD, in this, is acting just the same as the linux crowd is and to be quite frank, IMHO it's just plain silliness.