From owner-cvs-all  Fri Mar 15 10:17:46 2002
Delivered-To: cvs-all@freebsd.org
Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8258137B402; Fri, 15 Mar 2002 10:17:35 -0800 (PST)
Received: by flood.ping.uio.no (Postfix, from userid 2602)
	id 986D25347; Fri, 15 Mar 2002 19:17:33 +0100 (CET)
X-URL: http://www.ofug.org/~des/
X-Disclaimer: The views expressed in this message do not necessarily
  coincide with those of any organisation or company with
  which I am or have been affiliated.
To: obrien@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ffs ffs_softdep.c
References: <200203150406.g2F46Bw06312@freefall.freebsd.org>
	<xzpofhprj9v.fsf@flood.ping.uio.no>
	<20020315095447.C44160@dragon.nuxi.com>
From: Dag-Erling Smorgrav <des@ofug.org>
Date: 15 Mar 2002 19:17:32 +0100
In-Reply-To: <20020315095447.C44160@dragon.nuxi.com>
Message-ID: <xzppu25puf7.fsf@flood.ping.uio.no>
Lines: 22
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

"David O'Brien" <obrien@FreeBSD.org> writes:
>     error = 0;
> 
> at the beginning of the function is obfuscatation??

Hey, I'm not attacking your patch; I was aware of the problem and
considered committing the exact same patch myself.  I'm just annoyed
that gcc isn't able to determine that the loop always runs at least
once.  But maybe I'm wishing for the moon...  Anyway, I was bitching
at gcc, not at you.  Sorry if that wasn't clear.

>                                                      At the companies
> I've worked at, local variables were _required_ to be initialized after
> their definition.

Most of the time, this is a good idea, but sometimes it can hide real
errors; like forgetting to set error before returning when an error
actually occurs, so the caller thinks you succeeded.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message