From owner-svn-src-all@freebsd.org Thu Jul 30 18:31:59 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 682A63ABC78 for ; Thu, 30 Jul 2020 18:31:59 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BHfC22psNz3Vjp for ; Thu, 30 Jul 2020 18:31:58 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lf1-f54.google.com with SMTP id i80so15475614lfi.13 for ; Thu, 30 Jul 2020 11:31:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rrzwe31JDGy+p7jhmmjTBz4cyS5ibD+jbLuRSHG5ZPQ=; b=g6h6S12186rmVkXcO4jbFRqxYdrJi+mUvMCPGNP/WGpCWLxPkl9Cunpq+y58fO1iaB gZBTfD0Iznk/CVqQUC9lF3vOfjNbLzgwCT/fc0+Z8P8r6Fu0TNHOwo42RXorwFTyUmm/ 3LtYRi70WAPrbdK2bXRiWPo+OkswxwlYnhrwH0fPxXeyUfooRNh6/d5VpFTqguzg6rfX LsGHMBzsm0Lw5kp0ctsdvMKuUEUBL8mTu2KEp3PK+0Ryv0hDncuh0O3Q8VSzknRvPA7P rKlg6k4IZ7LvAKxghKc7HrVeinNziCtIqo7PAiRgxqe0nF5RRt70mOfuY2pfH7AY75W0 bi5Q== X-Gm-Message-State: AOAM532yXojcX/6eQoVOMsMBjDBegFKHn5QPZOFjS/EGVs3y0JRZiE2u nDkOg2FsyDnVEMKfKk8XbbrnsVU9 X-Google-Smtp-Source: ABdhPJyQnqc15VWH+g1ubaPG7jeUS1zmdqbi6qx8/2eoPs3a+WHVRiVpwnwh2EEJzvSFyMcyG6U52g== X-Received: by 2002:a19:74f:: with SMTP id 76mr605lfh.164.1596133916307; Thu, 30 Jul 2020 11:31:56 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id h18sm1178049lji.136.2020.07.30.11.31.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2020 11:31:55 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id v15so10956715lfg.6 for ; Thu, 30 Jul 2020 11:31:54 -0700 (PDT) X-Received: by 2002:a19:8b55:: with SMTP id n82mr2278855lfd.35.1596133914502; Thu, 30 Jul 2020 11:31:54 -0700 (PDT) MIME-Version: 1.0 References: <202006111559.05BFxnSa070435@repo.freebsd.org> <20200725.124911.256350108759170094.nyan@FreeBSD.org> In-Reply-To: <20200725.124911.256350108759170094.nyan@FreeBSD.org> From: Eric Joyner Date: Thu, 30 Jul 2020 11:31:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r362063 - head/sys/dev/e1000 To: Yoshihiro Takahashi Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4BHfC22psNz3Vjp X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-2.10 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.001]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.38)[-0.382]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.54:from]; NEURAL_HAM_MEDIUM(-0.72)[-0.718]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.54:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 18:31:59 -0000 Done in r363711. I apologize for it taking so long. On Fri, Jul 24, 2020 at 8:49 PM Yoshihiro Takahashi wrote: > Please merge this change to stable/12 branch until a proper fix is > done. > > --- > Yoshihiro Takahashi > > In article <202006111559.05BFxnSa070435@repo.freebsd.org> > Eric Joyner writes: > > > Author: erj > > Date: Thu Jun 11 15:59:49 2020 > > New Revision: 362063 > > URL: https://svnweb.freebsd.org/changeset/base/362063 > > > > Log: > > em(4): Always reinit interface when adding/removing VLAN > > > > This partially reverts r361053 since there have been reports > > by users that this breaks some functionality for em(4) > > devices; it seems at first glance that some sort of interface > > restart is required for those cards. > > > > This isn't a proper fix; this unbreaks those users until a proper > > fix is found for their issues. > > > > PR: 240818 > > Reported by: Marek Zarychta > > MFC after: 3 days > > > > Modified: > > head/sys/dev/e1000/if_em.c > > > > Modified: head/sys/dev/e1000/if_em.c > > > ============================================================================== > > --- head/sys/dev/e1000/if_em.c Thu Jun 11 15:17:13 2020 > (r362062) > > +++ head/sys/dev/e1000/if_em.c Thu Jun 11 15:59:49 2020 > (r362063) > > @@ -4059,7 +4059,6 @@ em_if_needs_restart(if_ctx_t ctx __unused, enum > iflib_ > > { > > switch (event) { > > case IFLIB_RESTART_VLAN_CONFIG: > > - return (false); > > default: > > return (true); > > } >