From owner-cvs-all Thu Aug 1 6:45:16 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 814A437B400; Thu, 1 Aug 2002 06:45:01 -0700 (PDT) Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0BC4D43E5E; Thu, 1 Aug 2002 06:44:59 -0700 (PDT) (envelope-from iwasaki@jp.FreeBSD.org) Received: from localhost (iwa@localhost [127.0.0.1]) by tasogare.imasy.or.jp (8.11.6+3.4W/8.11.6/tasogare) with ESMTP/inet id g71DivY15793; Thu, 1 Aug 2002 22:44:57 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) To: jhb@FreeBSD.org Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/i386/acpica acpi_wakeup.c In-Reply-To: References: <200208010948.g719m2DZ068561@freefall.freebsd.org> X-Mailer: Mew version 1.94.1 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20020801224457E.iwasaki@jp.FreeBSD.org> Date: Thu, 01 Aug 2002 22:44:57 +0900 From: Mitsuru IWASAKI X-Dispatcher: imput version 20000228(IM140) Lines: 33 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On 01-Aug-2002 Mitsuru IWASAKI wrote: > > iwasaki 2002/08/01 02:48:02 PDT > > > > Modified files: > > sys/i386/acpica acpi_wakeup.c > > Log: > > Fix a bug about stack manipulation at ACPI wakeup. > > This should avoid kernel panic on kernel compiled w/o > > NO_CPU_COPTFLAGS. > > > > Suggested by: optimized code by -mcpu=pentiumpro > > Sorry I couldn't help you with this earlier. Thanks for fixing it! > I have a couple of questions about acpu_restorecpu(): > > 1) Why bother moving r_eax into %eax when you zero %eax anyways > right before returning? Maybe we were too honest, wanted to restore A to D :) > 2) To make the code perhaps a bit easier to follow (esp. to explain > why you had to add the popl) maybe you could remove the extra > pop and change the last 3 lines to look like this: > > movl ret_addr,%eax # override \n\ > movl %eax,(%esp) # ret addr \n\ > xorl %eax,%eax \n\ > ret \n\ Ah, this is much better, thanks! I will also remove extra popl added in my previous commit later on. Thanks again! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message