From nobody Mon Jul 7 14:23:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbRKy1Zsbz61qhx; Mon, 07 Jul 2025 14:23:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbRKx5tvmz3ZvT; Mon, 07 Jul 2025 14:23:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751898197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qsYpLSw7t87s/aWVyHMN8/T25h9xk0UjQqpfG6AMwLQ=; b=TqxhSYJI9i9dDDX7GdrYNxSqQOG1qcV7kiCBtm7i7DUmApqyjLDZ45/Io/60FB/NrUFvfW bH5/Mu78Jh0uz/2XvMBaUl1ltdLKKIfAIZ17yMz7YOEqUyC5x7/8KXCr4FqmCruW+VJHYC r3vh98JrUEm73MieSCgWSnLJhq9SzV9sDw5lmcdNrvnfQ+ahSK6qNaPJMwxmittP2XUMea 7JPuNV1VJyZjCcxnj2lLLG3zfgbXmsxszbKPZpGlLNl4Pe6w0pG/kZEGHoLM5jv4VvboIE d+MaQQatemz5dqGEXGIVTTwLQxgkND84FVNEFXhe8ZaGd8bN+Qcyz7adhAWZBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751898197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qsYpLSw7t87s/aWVyHMN8/T25h9xk0UjQqpfG6AMwLQ=; b=xfnM3m9X5ZixTm8IGMxcs1xhRSwC9YGH9VCJF7vgNPclVfq1ow1xv8vbB/Lgbi+J47/Tak RMa16VkjxiJiPwzGkL3bduoa8/C+A5H60myMmtmPNAmdJ6IWvQ49pi6Qm7qt0naOC6ln4t xMzrbEo/HRQ8fPGau+Rlid63iyIWkRXZ+/8ZdvI/e6mDmVKXHDPtUHAk4pV9LUmuqAXVWN RFzKwJvOuwq6ffcrOxKGZtK+g8zl1rgd0bMGc7BK5poXG034Wyrx8xh7sXJgsQZE6Ak2L0 3gsOIC98PCXx4p8SpvND53iqdKtfdmO7cbA3sfn6fp9pu/05XRZaPZCB4HFcqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751898197; a=rsa-sha256; cv=none; b=lRI/lOYUmx0IwaZGOY1Fx24rfqnXyZdZa9AU4vF9612yEsT4CWfGFNnv8Xe6LcFqpSNbrP HTM7PABNzjOBv9Z0vn/FBOhMOCXeqFiX5+ZS+b2LxKn+L05CN6e1yj3C9JBvs8KdiSpbiP la4QCA/WAMFZ+G+7hrtRDuAQqo1A1Y3hl4NDMx8iV4ySaSoH+x+VQOtbF274V/l9mxpEG5 Wl8y9zonmIGNDgOhcgG8AFRmQ+KTUDfvQyygx4A88jjJqDqMVUIYV1ThCdSc2qnh5b1KTb rSk2dOnH2SEKlxpqnyCwqk/4VEAg+7dEb7H2CFaU+Uo4XwBmGDEVAP4iw5E45g== Received: from [IPV6:2601:5c0:4200:b830:459f:451:1697:9d58] (unknown [IPv6:2601:5c0:4200:b830:459f:451:1697:9d58]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bbRKx3nzWz1QSm; Mon, 07 Jul 2025 14:23:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Mon, 7 Jul 2025 10:23:16 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4685fa8e4bef - main - aio: handle errors from fork Content-Language: en-US To: Konstantin Belousov , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202507052119.565LJIrH099925@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202507052119.565LJIrH099925@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/5/25 17:19, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4685fa8e4bef169e6a1ceaf07f149232326de805 > > commit 4685fa8e4bef169e6a1ceaf07f149232326de805 > Author: Konstantin Belousov > AuthorDate: 2025-07-04 18:30:31 +0000 > Commit: Konstantin Belousov > CommitDate: 2025-07-05 21:18:43 +0000 > > aio: handle errors from fork > > Do not try to fork forever if fork() failed. Propagate the error up. > > Reported and tested by: pho > Sponsored by: The FreeBSD Foundation > MFC after: 1 week I'm not sure this is always correct? Certainly we should not loop forever, but as long as one AIO worker exists, it is safe to continue and not report an error. Having multiple AIO workers is a performance optimization, not a functionality requirement. That is, I think aio_init_aioinfo() should only report an error if num_aio_procs is zero after the loop. -- John Baldwin