From owner-freebsd-hackers@FreeBSD.ORG  Sun Jun 10 13:34:11 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D6FB106564A;
	Sun, 10 Jun 2012 13:34:11 +0000 (UTC)
	(envelope-from freebsd-listen@fabiankeil.de)
Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de
	[80.67.31.25]) by mx1.freebsd.org (Postfix) with ESMTP id BF7D88FC0C;
	Sun, 10 Jun 2012 13:34:10 +0000 (UTC)
Received: from [78.35.164.130] (helo=fabiankeil.de)
	by smtprelay02.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.68) (envelope-from <freebsd-listen@fabiankeil.de>)
	id 1SdiBl-0008T2-3T; Sun, 10 Jun 2012 15:28:17 +0200
Date: Sun, 10 Jun 2012 15:27:21 +0200
From: Fabian Keil <freebsd-listen@fabiankeil.de>
To: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <20120610152721.3b627896@fabiankeil.de>
In-Reply-To: <4FD490D5.1070207@FreeBSD.org>
References: <4FD490D5.1070207@FreeBSD.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=PGP-SHA1;
	boundary="Sig_/0505RVOCRjn_Zz7F5zv4atD";
	protocol="application/pgp-signature"
X-Df-Sender: Nzc1MDY3
Cc: freebsd-hackers@freebsd.org
Subject: Re: decoding of multi-byte nops in dtrace
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jun 2012 13:34:11 -0000

--Sig_/0505RVOCRjn_Zz7F5zv4atD
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Andriy Gapon <avg@FreeBSD.org> wrote:

> It seems that the $subj is missing :-)
> In my environment that causes many functions to not have fbt return probe,
> because function body decoding fails before 'ret' is found.
>=20
> Here is my attempt at fixing the problem:
> http://people.freebsd.org/~avg/fbt-nop.patch
> Reviews and suggestions are welcome.

The patch seems to reduce the number of missing
fbt return probes by about 50% for me.

Without the patch:

fk@r500 /usr/src $sudo dtrace -ln fbt::: | grep -c entry
23395
fk@r500 /usr/src $sudo dtrace -ln fbt::: | grep -c return
16739

With the patch (and updated kernel sources):

fk@r500 ~ $sudo dtrace -ln fbt::: | grep -c entry
23409
fk@r500 ~ $sudo dtrace -ln fbt::: | grep -c return
19879

Thanks
Fabian

--Sig_/0505RVOCRjn_Zz7F5zv4atD
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAk/UoL4ACgkQBYqIVf93VJ2+wQCfVfvCivnU3Dn/iJZcivJ2JDeD
C9UAnR+zvUV5C/VekYP3obj07yJhSSEK
=k1kq
-----END PGP SIGNATURE-----

--Sig_/0505RVOCRjn_Zz7F5zv4atD--