Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Nov 2018 17:03:54 +0000 (UTC)
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r340072 - head/sys/netpfil/pf
Message-ID:  <201811021703.wA2H3swP035238@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kp
Date: Fri Nov  2 17:03:53 2018
New Revision: 340072
URL: https://svnweb.freebsd.org/changeset/base/340072

Log:
  pfsync: Add missing unlock
  
  If we fail to set up the multicast entry for pfsync and return an error
  we must release the pfsync lock first.
  
  MFC after:	2 weeks
  Sponsored by:	Orange Business Services
  Differential Revision:	https://reviews.freebsd.org/D17506

Modified:
  head/sys/netpfil/pf/if_pfsync.c

Modified: head/sys/netpfil/pf/if_pfsync.c
==============================================================================
--- head/sys/netpfil/pf/if_pfsync.c	Fri Nov  2 17:02:10 2018	(r340071)
+++ head/sys/netpfil/pf/if_pfsync.c	Fri Nov  2 17:03:53 2018	(r340072)
@@ -1394,6 +1394,7 @@ pfsyncioctl(struct ifnet *ifp, u_long cmd, caddr_t dat
 			if (error) {
 				if_rele(sifp);
 				free(mship, M_PFSYNC);
+				PFSYNC_UNLOCK(sc);
 				return (error);
 			}
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811021703.wA2H3swP035238>