From owner-freebsd-hackers Tue Apr 17 14:14:10 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 0E34C37B424 for ; Tue, 17 Apr 2001 14:14:08 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.2/8.11.2) id f3HLDxP07733; Tue, 17 Apr 2001 14:13:59 -0700 (PDT) (envelope-from dillon) Date: Tue, 17 Apr 2001 14:13:59 -0700 (PDT) From: Matt Dillon Message-Id: <200104172113.f3HLDxP07733@earth.backplane.com> To: Poul-Henning Kamp Cc: Alfred Perlstein , Kirk McKusick , Julian Elischer , Rik van Riel , freebsd-hackers@FreeBSD.ORG, David Xu Subject: Re: vm balance References: <27879.987541244@critter> Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :> reference to me. I'm not even sure why they bother to check v_id. :> The vp reference from an nfsnode is a hard reference. :> : :Well, if that's the case, yank all uses of v_id from the nfs code, :I'll do the namecache and vnodes can be deleted to the joy of our users... : :-- :Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 :phk@FreeBSD.ORG | TCP/IP since RFC 956 If you can yank v_id out from the kern/vfs_cache code, I will make similar fixes to the NFS code. I am not particularly interesting in returning vnodes to the MALLOC pool myself, but I am interested in fixing the two bugs I noticed when I ran over the code earlier today. Actually one bug. The vput() turns out to be correct, I just looked at the code again. However, the cache_lookup() call in nfs_vnops.c is broken. Assuming no other fixes, the vpid load needs to occur before the VOP_ACCESS call rather then after. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message