From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Nov 16 12:30:19 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F39A16A420 for ; Wed, 16 Nov 2005 12:30:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B5ABF43D55 for ; Wed, 16 Nov 2005 12:30:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jAGCUHLa060071 for ; Wed, 16 Nov 2005 12:30:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jAGCUHmV060068; Wed, 16 Nov 2005 12:30:17 GMT (envelope-from gnats) Resent-Date: Wed, 16 Nov 2005 12:30:17 GMT Resent-Message-Id: <200511161230.jAGCUHmV060068@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pawel Wieleba Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4A91916A41F for ; Wed, 16 Nov 2005 12:23:13 +0000 (GMT) (envelope-from wielebap@amper.iem.pw.edu.pl) Received: from amper.iem.pw.edu.pl (amper.iem.pw.edu.pl [194.29.146.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id AD06343D5D for ; Wed, 16 Nov 2005 12:23:11 +0000 (GMT) (envelope-from wielebap@amper.iem.pw.edu.pl) Received: by amper.iem.pw.edu.pl (Postfix, from userid 2556) id 0291327509; Wed, 16 Nov 2005 13:23:10 +0100 (CET) Message-Id: <20051116122310.0291327509@amper.iem.pw.edu.pl> Date: Wed, 16 Nov 2005 13:23:09 +0100 (CET) From: Pawel Wieleba To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/89117: [PATCH] audio/sox; enable OPTIONS; configure KNOBS via dialog X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Pawel Wieleba List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2005 12:30:19 -0000 >Number: 89117 >Category: ports >Synopsis: [PATCH] audio/sox; enable OPTIONS; configure KNOBS via dialog >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Wed Nov 16 12:30:16 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Pawel Wieleba >Release: FreeBSD 7.0-CURRENT i386 >Organization: >Environment: System: FreeBSD srv 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Mon Oct 31 17:22:48 CET 2005 root@srv:/usr/src/sys/i386/compile/SRV i386 >Description: This port doesn't support configuration via dialog (doesn't support options). >How-To-Repeat: "make config" is not supported >Fix: I've added OPTIONS support to audio/sox port in the patch: --- Makefile.diff begins here --- --- Makefile-OLD Thu Oct 6 05:40:12 2005 +++ Makefile Wed Nov 16 12:17:23 2005 @@ -21,6 +21,10 @@ GNU_CONFIGURE= yes MAKE_ENV= PLAY_SUPPORT=1 +OPTIONS= LAME "Enable mp3 encoding with LAME" off \ + MAD "Enable mp3 decoding with MAD" off \ + VORBIS "Enable Ogg Vorbis support" off + .include .if exists(${LOCALBASE}/lib/libmp3lame.so.0) @@ -60,17 +64,6 @@ LIB_DEPENDS+= mad.2:${PORTSDIR}/audio/libmad .else CONFIGURE_ARGS+= --disable-mad -.endif - -pre-fetch: -.if !defined(WITH_LAME) - @${ECHO_MSG} "You can enable mp3 encoding by defining WITH_LAME." -.endif -.if !defined(WITH_MAD) - @${ECHO_MSG} "You can enable mp3 decoding by defining WITH_MAD." -.endif -.if !defined(WITH_VORBIS) - @${ECHO_MSG} "You can enable Ogg Vorbis support by defining WITH_VORBIS." .endif .include --- Makefile.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: