From owner-freebsd-bugs  Fri Jul 25 08:18:09 1997
Return-Path: <owner-freebsd-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id IAA07778
          for bugs-outgoing; Fri, 25 Jul 1997 08:18:09 -0700 (PDT)
Received: from hades.dcs.napier.ac.uk (hades.dcs.napier.ac.uk [146.176.161.1])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA07773
          for <freebsd-bugs@freebsd.org>; Fri, 25 Jul 1997 08:18:03 -0700 (PDT)
Received: from artemis.dcs.napier.ac.uk (artemis [146.176.161.5]) by hades.dcs.napier.ac.uk (8.7.3/8.7.3) with ESMTP id QAA14687 for <freebsd-bugs@freebsd.org>; Fri, 25 Jul 1997 16:20:03 +0100 (BST)
Received: (from bsc4093@localhost) by artemis.dcs.napier.ac.uk (8.7.3/8.7.3) id QAA02962; Fri, 25 Jul 1997 16:20:22 +0100 (BST)
Date: Fri, 25 Jul 1997 16:20:21 +0100 (BST)
From: Robin Carey <r.carey@dcs.napier.ac.uk>
To: freebsd-bugs@freebsd.org
Subject: Hello boys its me again.
Message-ID: <Pine.SOL.3.91.970725161441.2931A-100000@artemis>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Sorry for not send-pr'ing this ... I noticed this the other day:

Basically you've got bzero(3) and bcopy(3) being used in
/usr/include/sys/types.h for the FD_ZERO() and FD_SET() macros, and you've
not included <stdlib.h> - or is it <string.h> - never can tell with these
dodgy non-ANSI calls :) This results in a warning with gcc -Wall if you
don't accidentally include the right header before <sys/types.h> .... I'd
suggest changing them to memset(3) and memcpy(3) respectively, which are 
ANSI and need <string.h>. BTW Are those FD_*() macros meant to be in 
<sys/types.h> ? I'd have thought <unistd.h> would be a better place, but 
thats just my warped sense of direction :)

L8r.