From nobody Sat Apr 5 16:30:37 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZVLYp33wzz5sRBd; Sat, 05 Apr 2025 16:30:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZVLYp0rfMz3GVR; Sat, 05 Apr 2025 16:30:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743870638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wJm8LvtfE6vgpLMyqIBhBZCjFHZDoDhpngEdgHyzfVc=; b=Neb1xQh6fe3mUuP4jQvPk4J4xi/ok6iwjAazK0r6dyCEERaV3xZewnPzGXUtbMuC01Mvts 7WGpmhYsUWhlCRhnl3WwpzBxTaTM0KUwF1cAqGWgvXXyIPpps6JyA6EfPtYSJvZ9JxiuyP vKR2MG9aPw3IG2uDWy8EHywInHRiIwa2XUlzRYoeQNhX68io5NWeVHBI5LfAQPkwz0yF8n sIRXhjGXE7Q9bwDfV7FDW6SgJ2Cd2L69baZnl93tvd6eq3iWF3C9QMX+j7Rza3CK0FnqxC uAJEVcLX+FyQc28vIUfPeSCrtpz3HIAhpEIG7B4kDwQz9Rnnzkb3ThMscg26aA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743870638; a=rsa-sha256; cv=none; b=WpLN4ANlTdHe0SxolhLLdHQ/pawUe9WjLHxnHiKjUby8kRmVnBntzNeO7fUE0EjDqEyZLW YJsQdiPwvWGWNiPbNdkp60Xe6LE6Maa2jRisPuzlnPN0HJsM65nO4boeQhYPEnmHWUescs uMBmL0TAaoMl2gQD6ZYygGzqwLewbWrfyi8gNCfkbpd21FA7soXy1AY9IB3PfWcwJxnn8b ZK5210tBAvUzyFs3EGJUH/h2rq/tHugDvAvNQKv8TzZQWTZwi/iGTcbGeZI4YteyTvHjIF ouTZK+LU2Tm6DCA1nhNkoqd9LoIyyqo2eXnT8IpbJ0PmnS6ITrcJ6SfA1YRfaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743870638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wJm8LvtfE6vgpLMyqIBhBZCjFHZDoDhpngEdgHyzfVc=; b=lbC4l0ecoj8x3KzQQCm19bP4p1FXLeCywCT48Ww4CKpYleVcXHaWVSLiZqFDKjedwOcBS4 1WlcSDhR+IQA0qZV640PsrkxZLcttFgA5NzgT984HVU5MiQfMZd8xyPD8Z1EOi8W9QD43/ 9JVblEzd8ROMrfysW9ImK/MTS9eICrlUONkFGq4dGLk4rSAi+KNDCYZW3rFoxMx2aNAF41 DKJPDxIdQlS4X5KnsDxHAZxUAGPufxYEoJeUeRHC9KI5yqA9Q/4AXQK6Ajnn6omJ9IZ9zc aY2uzE8JV8vbXqv000kF1fWb6mTukz7rJjkfoLNL9Vl3LfXYB8U+Ik4rmuRQ2w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZVLYp09bvz7rt; Sat, 05 Apr 2025 16:30:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 535GUbQB077924; Sat, 5 Apr 2025 16:30:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 535GUbDN077921; Sat, 5 Apr 2025 16:30:37 GMT (envelope-from git) Date: Sat, 5 Apr 2025 16:30:37 GMT Message-Id: <202504051630.535GUbDN077921@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: c5773d366ecc - main - ktr: Make debug.ktr.verbose available whenever KTR is configured List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c5773d366ecc5271b9bd6e5506c00fb3520f19ae Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c5773d366ecc5271b9bd6e5506c00fb3520f19ae commit c5773d366ecc5271b9bd6e5506c00fb3520f19ae Author: Mark Johnston AuthorDate: 2025-04-05 16:23:51 +0000 Commit: Mark Johnston CommitDate: 2025-04-05 16:29:44 +0000 ktr: Make debug.ktr.verbose available whenever KTR is configured This is more useful and matches the documentation. While here, make it settable as a tunable and add a sysctl description. PR: 139425 MFC after: 2 weeks --- sys/kern/kern_ktr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/kern/kern_ktr.c b/sys/kern/kern_ktr.c index e862816c4613..cbd32d13248a 100644 --- a/sys/kern/kern_ktr.c +++ b/sys/kern/kern_ktr.c @@ -251,9 +251,12 @@ SYSCTL_PROC(_debug_ktr, OID_AUTO, entries, #ifdef KTR_VERBOSE int ktr_verbose = KTR_VERBOSE; -TUNABLE_INT("debug.ktr.verbose", &ktr_verbose); -SYSCTL_INT(_debug_ktr, OID_AUTO, verbose, CTLFLAG_RW, &ktr_verbose, 0, ""); +#else +int ktr_verbose = 0; #endif +TUNABLE_INT("debug.ktr.verbose", &ktr_verbose); +SYSCTL_INT(_debug_ktr, OID_AUTO, verbose, CTLFLAG_RWTUN, &ktr_verbose, 0, + "Print extra info when logging to the console"); #ifdef KTR_ALQ struct alq *ktr_alq; @@ -375,7 +378,6 @@ ktr_tracepoint(uint64_t mask, const char *file, int line, const char *format, file += 3; entry->ktr_file = file; entry->ktr_line = line; -#ifdef KTR_VERBOSE if (ktr_verbose) { #ifdef SMP printf("cpu%d ", cpu); @@ -387,7 +389,6 @@ ktr_tracepoint(uint64_t mask, const char *file, int line, const char *format, printf(format, arg1, arg2, arg3, arg4, arg5, arg6); printf("\n"); } -#endif entry->ktr_desc = format; entry->ktr_parms[0] = arg1; entry->ktr_parms[1] = arg2;