Date: Thu, 18 Nov 2004 09:37:02 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: soralx@cydem.org Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Re: Linksys PCM200 Message-ID: <20041118.093702.34542518.imp@bsdimp.com> In-Reply-To: <200411180014.52267.soralx@cydem.org> References: <417B08B5.8080208@error404.nls.net> <417BE411.8070500@error404.nls.net> <200411180014.52267.soralx@cydem.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200411180014.52267.soralx@cydem.org>
<soralx@cydem.org> writes:
:
: > Okay, so I got unlazy and threw some stuff together. Try these patches;
: > this will default the PCM200 cards to store-and-forward. This might help.
: > -ksaihr
: [...]
: > --- /usr/src/sys/pci/if_dcreg.h Thu Aug 5 13:46:14 2004
: > +++ if_dcreg.h Sun Oct 24 13:09:31 2004
: > @@ -98,6 +98,13 @@
: > #define DC_IS_XIRCOM(x) (x->dc_type == DC_TYPE_XIRCOM)
: > #define DC_IS_CONEXANT(x) (x->dc_type == DC_TYPE_CONEXANT)
: >
: > +/* Cards requiring specific workaround */
: > + /* Linksys PCM200 */
: > +#define DC_IS_LINKSYS(x) \
: > + (x->dc_type == DC_TYPE_AN985 && \
: > + pci_get_vendor(dev) == DC_VENDORID_LINKSYS && \
: > + pci_get_device(dev) == DC_DEVICEID_PCM200_AB08)
: > +
: > /* MII/symbol mode port types */
: > #define DC_PMODE_MII 0x1
: > #define DC_PMODE_SYM 0x2
:
: I've tested the patch. The kernel won't compile with it: 'dev' [as in
: pci_get_vendor(dev)] is not defined. Don't have time now to investigate :(
You likely shouldn't have IS_LINKSYS here. There's all manner of
ugliness in the dc driver that should more properly be handled by
better use of a flags quirk word.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041118.093702.34542518.imp>