From owner-freebsd-current@freebsd.org Thu Nov 7 15:36:14 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 310D01B7D8E for ; Thu, 7 Nov 2019 15:36:14 +0000 (UTC) (envelope-from phil@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4786v058Y7z3LtX; Thu, 7 Nov 2019 15:36:12 +0000 (UTC) (envelope-from phil@juniper.net) Received: from pps.filterd (m0108157.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xA7FQw4s022832; Thu, 7 Nov 2019 07:36:00 -0800 Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2056.outbound.protection.outlook.com [104.47.38.56]) by mx0a-00273201.pphosted.com with ESMTP id 2w41vcj2hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Nov 2019 07:36:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ls1OCJwNCvOODYdwZfGemd6fiSBMLlXrI/mxk8wtJOGzzLz4lldMjilAC4YdrHn6f0AHsJboHHxndX5+7tmmBtpLfPyJzbRAZQbHz4dhpIw9BvTWcdSDQFngSohvydQHa9400H7I+OMvI3DMtcHtmEVj/skK13Et4hrvv0dfvBjFxJaktr4H04eAnL7xJajVbRKn913IRli74rIXkA9F4Pk8DhEt1rpAfAHDiL7yaJJ7/6wklLisXYOCdDpKa+mwoxOBdfNvdrgL9M0OTicS3tHLSU3n8W5ZevKRwjXEsZcqyrgfmqByJdV/pGADRi7IPntxM7Huf4cp33exz9ltwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dvL+bxTWJ7B56Z97o6h5QubS9FZY0kZYHeap1zF5omI=; b=aNs+XKfZaDv/VsCACL7vveVyMvJVLUaSxvR4MTj9+B8uu8HuBo5ojsnFVXF9XjTCf3BznPr0EWEUrPC5r/ZwXV8vQXTnC53w62fKosysy0R090D2bY2ZJlK0nbKJ2sC2a4bdLFhl0vPNEBtX/BnGpTpI/F3C5MWWcPUYd5iyMXSkJja3UfroxLfzVC4QG36sZxBksYWRCX4thTg4KFCPPgk+LTrcUQs+ovW4QP6o35bI0cFCw2A1mNnAB9fU2RFaztRE/iQjTR5sv1tvRW64FyQo5UGkpUGm/JZTFeBopgGgURDdAK2S1sMnxj4h57TbTUQt9LbmCN/rLNB6j6NJjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.12) smtp.rcpttodomain=stacktic.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none Received: from SN4PR0501CA0041.namprd05.prod.outlook.com (2603:10b6:803:41::18) by SN6PR05MB4736.namprd05.prod.outlook.com (2603:10b6:805:93::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.13; Thu, 7 Nov 2019 15:35:57 +0000 Received: from CO1NAM05FT025.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::200) by SN4PR0501CA0041.outlook.office365.com (2603:10b6:803:41::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.16 via Frontend Transport; Thu, 7 Nov 2019 15:35:57 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from P-EXFEND-EQX-01.jnpr.net (66.129.239.12) by CO1NAM05FT025.mail.protection.outlook.com (10.152.96.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2451.15 via Frontend Transport; Thu, 7 Nov 2019 15:35:57 +0000 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXFEND-EQX-01.jnpr.net (10.104.8.54) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 7 Nov 2019 07:35:56 -0800 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 7 Nov 2019 07:35:56 -0800 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 7 Nov 2019 07:35:56 -0800 Received: from idle.juniper.net (idleski.juniper.net [172.25.5.10]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id xA7FZrCX012178; Thu, 7 Nov 2019 07:35:55 -0800 (envelope-from phil@juniper.net) Received: from [10.0.0.3] (localhost [127.0.0.1]) by idle.juniper.net (8.15.2/8.15.2) with ESMTP id xA7FX1xn080698; Thu, 7 Nov 2019 10:33:01 -0500 (EST) (envelope-from phil@juniper.net) From: Phil Shafer To: Arnaud Ysmal CC: , , Subject: Re: Segmentation fault in netstat after r354373 -> r354373 update Date: Thu, 7 Nov 2019 10:38:20 -0500 X-Mailer: MailMate (1.13r5655) Message-ID: <0FC9A86B-95E4-427E-AF7E-518470C995B2@juniper.net> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(39860400002)(396003)(346002)(136003)(376002)(199004)(189003)(47776003)(2906002)(86362001)(305945005)(50466002)(33656002)(4326008)(6246003)(356004)(8936002)(336012)(186003)(229853002)(6666004)(316002)(6916009)(4744005)(53546011)(36756003)(50226002)(70586007)(8676002)(81156014)(2616005)(81166006)(11346002)(16586007)(26005)(7126003)(70206006)(76176011)(478600001)(426003)(126002)(446003)(486006)(476003)(76506006)(5660300002)(51416003)(54906003)(781001); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR05MB4736; H:P-EXFEND-EQX-01.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb29c559-b348-4557-5bad-08d763982f23 X-MS-TrafficTypeDiagnostic: SN6PR05MB4736: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0214EB3F68 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mP5NLR9dH9Kf1KlQwYhWcMnXJ838zPjKx14VA2u8p7F9nQwP3/GVxsdTb4mRRkfcQXyqagpEJdb+pPX+J0ylshnV74Kg2vmeamYNGdPesKoGyjqV0i050RrfJRKYfHSa/lVzpGVwk9loqvtZP0vmfC842wFRVPamHTLqMb+hcBZVCjeHj4oFnWC8dWGTTgdGuyZfVXIOl0vXi4PbbCLughfMEwjqx0mDYYwiJqRm/SHWhOwdUYanIy0srFROcYIrEy2uRWmTtMf9K9ZnU5Fs9qPk3azNayVVJ2zkH4poPBkzIY70Xw6ps3h4p8qDpGRWHTTB1DFgVu/SjRHZz3AHbpuYgpuOMOtANUVmWfwS+0vd5H4qaip10C1+8D2xq+p5Kl0IPybZRX5ew3tSIwf/2piSVwP2GxuaZYuyQAzOs3AmvXQQuUwa59fkHFOxs1+U X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2019 15:35:57.1888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb29c559-b348-4557-5bad-08d763982f23 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[P-EXFEND-EQX-01.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB4736 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-07_05:2019-11-07,2019-11-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=754 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1911070147 X-Rspamd-Queue-Id: 4786v058Y7z3LtX X-Spamd-Bar: ++ X-Spamd-Result: default: False [2.85 / 15.00]; RCVD_COUNT_SEVEN(0.00)[11]; RECEIVED_SPAMHAUS_XBL(5.00)[12.239.129.66.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.4]; R_DKIM_ALLOW(0.00)[juniper.net:s=PPS1017,juniper.net:s=selector1]; NEURAL_HAM_MEDIUM(-0.63)[-0.629,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(0.00)[+ip4:208.84.65.16]; NEURAL_HAM_LONG(-0.41)[-0.410,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[juniper.net:+]; DMARC_POLICY_ALLOW(0.00)[juniper.net,reject]; IP_SCORE(-1.01)[ip: (-2.18), ipnet: 208.84.65.0/24(-1.09), asn: 26211(-1.72), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[16.65.84.208.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:26211, ipnet:208.84.65.0/24, country:US]; ARC_ALLOW(0.00)[i=1]; MID_RHS_MATCH_FROM(0.00)[] X-Mailman-Approved-At: Fri, 08 Nov 2019 02:10:00 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2019 15:36:14 -0000 My bad. Will role a fix asap. Thanks, Phil On 7 Nov 2019, at 10:08, Arnaud Ysmal wrote: > Hi, > > I just got the same issue, it happens when argv[0] does not contain a > / (calling uptime segfault but calling /usr/bin/uptime works). > > In xo_parse_args there is no check whether cp is NULL before calling > xo_streq. > > I fixed it by changing this line: > - cp = &cp[len + 1 - sizeof(gnu_ext)]; > + cp = (char *)(uintptr_t)(const char *)(&xo_program[len + 1 - > sizeof(gnu_ext)]); > > Arnaud Ysmal