From owner-freebsd-current@FreeBSD.ORG  Fri Feb 14 10:38:21 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1F2C9F56;
 Fri, 14 Feb 2014 10:38:21 +0000 (UTC)
Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A19261852;
 Fri, 14 Feb 2014 10:38:19 +0000 (UTC)
X-IronPort-AV: E=Sophos;i="4.95,844,1384300800"; d="scan'208";a="100742221"
Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net)
 ([10.9.154.239])
 by FTLPIPO02.CITRIX.COM with ESMTP; 14 Feb 2014 10:38:17 +0000
Received: from [IPv6:::1] (10.80.16.47) by smtprelay.citrix.com (10.13.107.79)
 with Microsoft SMTP Server id 14.2.342.4;
 Fri, 14 Feb 2014 05:38:17 -0500
Message-ID: <52FDF217.3040005@citrix.com>
Date: Fri, 14 Feb 2014 11:38:15 +0100
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
Subject: Re: [PATCH RFC 10/13] xen: add ACPI bus to xen_nexus when running
 as Dom0
References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com>
 <1387884062-41154-11-git-send-email-roger.pau@citrix.com>
 <2410827.IqfpSAhe3T@ralph.baldwin.cx>
In-Reply-To: <2410827.IqfpSAhe3T@ralph.baldwin.cx>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Cc: julien.grall@citrix.com, freebsd-xen@freebsd.org,
 freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org,
 gibbs@freebsd.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Feb 2014 10:38:21 -0000

On 08/02/14 22:50, John Baldwin wrote:
> On Tuesday, December 24, 2013 12:20:59 PM Roger Pau Monne wrote:
>> Also disable a couple of ACPI devices that are not usable under Dom0.
> 
> Hmm, setting debug.acpi.disabled in this way is a bit hacky.  It might
> be fine however if there's no way for the user to set it before booting
> the kernel (as opposed to haing the relevant drivers explicitly disable
> themselves under Xen which I think would be cleaner, but would also
> make your patch larger)

Thanks for the review, the user can pass parameters to FreeBSD when
booted as Dom0, I just find it uncomfortable to force the user into
always setting something on the command line in order to boot.

What do you mean with "haing the relevant drivers explicitly disable
themselves under Xen"? Adding a gate on every one of those devices like
"if (xen_pv_domain()) return (ENXIO);" in the identify/probe routine
seems even worse.

Roger.