From nobody Sat May 30 17:42:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gSSJ81bp0z6gMX3; Sat, 30 May 2026 17:43:36 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp6.goneo.de (smtp6.goneo.de [85.220.129.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gSSJ65NLvz47Pd; Sat, 30 May 2026 17:43:34 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=walstatt-de.de header.s=DKIM001 header.b=B5Fdo61m; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@walstatt-de.de designates 85.220.129.31 as permitted sender) smtp.mailfrom=freebsd@walstatt-de.de Received: from hub2.goneo.de (hub2.goneo.de [85.220.129.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by smtp6.goneo.de (Postfix) with ESMTPS id 0E3E22401D3; Sat, 30 May 2026 19:43:33 +0200 (CEST) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id 2D7A3240282; Sat, 30 May 2026 19:43:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1780163011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=llrmIssZZALqfrsVAjiU2YmmhhPEHNpQPd74w6D8ZvQ=; b=B5Fdo61mr7h5rx84g7Yxtczbd2qnpJpXwFFiguGoV429KcgJyRS4oCbOH/CHEK71ypylLK R7WfsX0QFrV0Zsi7RQhMJy/JAc+eYYewDoy2f6iQprSSfq7LqR564IhLU+yslC5EKGANqf /KPGBxcc5o+OtjrC8j3cPFjhzJhIBP8QoObxv1XkwKryF6gb7XL1fFlF9oXKI29OXexg/1 E+AqmHhTdhwK2R31vLQLVk6B4ozKb5Mqz6Zt7sAzqbkiZv1edr1scMvdK+yzjGSMdCjkih ta53FwnS9AZKYiM+aUl/iD40UsKgAQ9QcSlF7+ET3a5Hs21Vib9pJWkhB9GaNg== Received: from thor.sb211.local (dynamic-2a02-3100-2914-f002-f829-ceb9-7bc5-38a6.310.pool.telefonica.de [IPv6:2a02:3100:2914:f002:f829:ceb9:7bc5:38a6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id D30BE24026C; Sat, 30 May 2026 19:43:30 +0200 (CEST) Date: Sat, 30 May 2026 19:42:57 +0200 From: A FreeBSD User To: Ahmad Khalifa Cc: src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2fa4bdd7f9e9 - main - edk2: enable static asserts for *INT64 alignment Message-ID: <20260530194324.288bac33@thor.sb211.local> In-Reply-To: <20260530190827.15ba6ffa@thor.sb211.local> References: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> <20260530190827.15ba6ffa@thor.sb211.local> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; amd64-portbld-freebsd16.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+wnf1+iJfbfRfGjifu4B=wN"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Rspamd-UID: 42d773 X-Rspamd-UID: 35224f X-Spamd-Result: default: False [-5.70 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; R_DKIM_ALLOW(-0.20)[walstatt-de.de:s=DKIM001]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:85.220.129.0/25]; RCVD_IN_DNSWL_LOW(-0.10)[85.220.129.31:from]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[walstatt-de.de]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@FreeBSD.org]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[walstatt-de.de:+] X-Spamd-Bar: ----- X-Rspamd-Queue-Id: 4gSSJ65NLvz47Pd --Sig_/+wnf1+iJfbfRfGjifu4B=wN Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Tage des Herren Sat, 30 May 2026 19:09:41 +0200 A FreeBSD User schrieb: > Am Tage des Herren Sat, 30 May 2026 02:45:12 +0000 > Ahmad Khalifa schrieb: >=20 > > The branch main has been updated by vexeduxr: > >=20 > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D2fa4bdd7f9e99698a6652db4= 05c3165fdcd41c1d > >=20 > > commit 2fa4bdd7f9e99698a6652db405c3165fdcd41c1d > > Author: Ahmad Khalifa > > AuthorDate: 2026-05-30 02:40:58 +0000 > > Commit: Ahmad Khalifa > > CommitDate: 2026-05-30 02:40:58 +0000 > >=20 > > edk2: enable static asserts for *INT64 alignment > > =20 > > The ia32 loader is now built with -malign-double, so these should p= ass. > > =20 > > Differential Revision: https://reviews.freebsd.org/D55386 > > --- > > sys/contrib/edk2/Include/Base.h | 2 -- > > 1 file changed, 2 deletions(-) > >=20 > > diff --git a/sys/contrib/edk2/Include/Base.h b/sys/contrib/edk2/Include= /Base.h > > index 3ae798db8429..d3342c9a6ca2 100644 > > --- a/sys/contrib/edk2/Include/Base.h > > +++ b/sys/contrib/edk2/Include/Base.h > > @@ -841,10 +841,8 @@ STATIC_ASSERT (ALIGNOF (INT16) =3D=3D sizeof (IN= T16), "Alignment of > > INT16 does not STATIC_ASSERT (ALIGNOF (UINT16) =3D=3D sizeof (UINT16),= "Alignment of UINT16 > > does not meet UEFI Specification Data Type requirements"); STATIC_ASSER= T (ALIGNOF (INT32) > > =3D=3D sizeof (INT32), "Alignment of INT32 does not meet UEFI Specific= ation Data Type > > requirements"); STATIC_ASSERT (ALIGNOF (UINT32) =3D=3D sizeof (UINT32)= , "Alignment of UINT32 > > does not meet UEFI Specification Data Type requirements"); -#ifndef _ST= ANDALONE > > STATIC_ASSERT (ALIGNOF (INT64) =3D=3D sizeof (INT64), "Alignment of INT= 64 does not meet UEFI > > Specification Data Type requirements"); STATIC_ASSERT (ALIGNOF (UINT64)= =3D=3D sizeof > > (UINT64), "Alignment of UINT64 does not meet UEFI Specification Data Ty= pe requirements"); > > -#endif STATIC_ASSERT (ALIGNOF (CHAR8) =3D=3D sizeof (CHAR8), "Alignm= ent of CHAR8 does not > > meet UEFI Specification Data Type requirements"); STATIC_ASSERT (ALIGNO= F (CHAR16) =3D=3D > > sizeof (CHAR16), "Alignment of CHAR16 does not meet UEFI Specification = Data Type > > requirements"); STATIC_ASSERT (ALIGNOF (INTN) =3D=3D sizeof (INTN), "Al= ignment of INTN does > > not meet UEFI Specification Data Type requirements"); > > =20 >=20 > The commit seems to disturb building process and gets rogue with: > [...] > In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBaseType= .h:16: > /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static assertion = failed due to > requirement '_Alignof(long long) =3D=3D sizeof(long long)': Alignment of = INT64 does not meet UEFI > Specification Data Type requirements 844 | STATIC_ASSERT (ALIGNOF (INT64)= =3D=3D sizeof > (INT64), "Alignment of INT64 does not meet UEFI Specification Data Type r= equirements"); | > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/edk2/Include/Ba= se.h:778:24: note: > expanded from macro 'ALIGNOF' >=20 >=20 > Regards > oh The commit seems to disturb building process and gets rogue with: [...] In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBaseType.h= :16: /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static assertion fa= iled due to requirement '_Alignof(long long) =3D=3D sizeof(long long)': Alignment of IN= T64 does not meet UEFI Specification Data Type requirements 844 | STATIC_ASSERT (ALIGNOF (INT64) = =3D=3D sizeof (INT64), "Alignment of INT64 does not meet UEFI Specification Data Type requirements= "); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/edk2/Include/Base= .h:778:24: note: expanded from macro 'ALIGNOF' Regards oh --=20 A FreeBSD user --Sig_/+wnf1+iJfbfRfGjifu4B=wN Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRQheDybVktG5eW/1Kxzvs8OqokrwUCahshvAAKCRCxzvs8Oqok r2pIAQCSJ3C3VKNjJe0B1qZc/QvQV45jSi1xU1Kf5MjkdIZNuQEAslSkqZymiwBh wGzbKHcWTF3mLnKdhRaDGWCKlMwC7QA= =2yMP -----END PGP SIGNATURE----- --Sig_/+wnf1+iJfbfRfGjifu4B=wN--