From nobody Mon Nov 15 13:11:22 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DB302183D9EB; Mon, 15 Nov 2021 13:11:24 +0000 (UTC) (envelope-from freebsd@toco-domains.de) Received: from toco-domains.de (mail.toco-domains.de [IPv6:2a01:4f8:151:4202::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ht8hr53yFz3qqs; Mon, 15 Nov 2021 13:11:24 +0000 (UTC) (envelope-from freebsd@toco-domains.de) Received: from [IPV6:2a02:908:1462:c2e0:f68c:50ff:fe3d:317d] (unknown [IPv6:2a02:908:1462:c2e0:f68c:50ff:fe3d:317d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by toco-domains.de (Postfix) with ESMTPSA id A0983715A; Mon, 15 Nov 2021 14:11:22 +0100 (CET) Message-ID: Date: Mon, 15 Nov 2021 14:11:22 +0100 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: git: 46ce086c7130 - main - Mk/Uses: default version for nodejs Content-Language: en-US To: Matthias Fechner , Po-Chuan Hsieh , bradleythughes@fastmail.fm Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202111120555.1AC5tGbw088641@gitrepo.freebsd.org> From: Torsten Zuehlsdorff In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Ht8hr53yFz3qqs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 15.11.21 09:16, Matthias Fechner wrote: > Am 14.11.2021 um 18:00 schrieb Po-Chuan Hsieh: >> Please revert the nodejs change. >> It is not approved. >> It should be committed after being accepted by all parties. >> As I mentioned in the review, I disagreed with the change of the >> default from www/node to www/node16. > > could you please let me know what is broken, then I will look into it? > > The modification has not only unbroken gitlab but also fixed many other > software packages (that are not part of ports) but do not work with node17. BTW: node16 does not compile for me so gitlab is still broken. Is this only me? o.O Best, Torsten