From owner-freebsd-current Sat Feb 1 21:44: 4 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 528A637B401 for ; Sat, 1 Feb 2003 21:44:03 -0800 (PST) Received: from nycsmtp1out.rdc-nyc.rr.com (nycsmtp1out.rdc-nyc.rr.com [24.29.99.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8ACB643E4A for ; Sat, 1 Feb 2003 21:44:02 -0800 (PST) (envelope-from mishchea@driftin.net) Received: from porch.driftin.net (66-108-249-254.nyc.rr.com [66.108.249.254]) by nycsmtp1out.rdc-nyc.rr.com (8.12.1/Road Runner SMTP Server 1.0) with ESMTP id h125i0wr029042; Sun, 2 Feb 2003 00:44:01 -0500 (EST) Received: by porch.driftin.net (Postfix, from userid 2000) id DDD825A01; Sun, 2 Feb 2003 00:48:57 +0000 (GMT) Date: Sun, 2 Feb 2003 00:48:57 +0000 From: Andrew Mishchenko To: Steve Kargl Cc: current@FreeBSD.ORG Subject: Re: Style fixups for proc.h Message-ID: <20030202004857.GB6673@driftin.net> References: <200302012246.h11MkEaX028068@grimreaper.grondar.org> <20030201235943.GA66200@troutmask.apl.washington.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030201235943.GA66200@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.3i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat 01 Feb, Steve Kargl wrote: > From: Steve Kargl > To: Julian Elischer > Cc: Mark Murray , julian@FreeBSD.ORG, current@FreeBSD.ORG > Subject: Re: Style fixups for proc.h > > On Sat, Feb 01, 2003 at 03:04:32PM -0800, Julian Elischer wrote: > > I don't know about the protection with a '_'. > > > > It's not standard and usually the name matches that used in the actual > > function. > > > > It's certainly not part of style(9) that I've ever noticed > > and it's generally noy done that way.. is there a move to do this on all > > the other files? > > > > man 9 style > > In header files visible to userland applications, prototypes that are > visible must use either ``protected'' names (ones beginning with an > underscore) or no names with the types. It is preferable to use pro- > tected names. E.g., use: > > void function(int); > > or: > > void function(int _fd); > Since having actual names in can be helpful if the names are relevant, but having dozens of *_p floating all over the place is not more easily readable, why not leave names out completely when they are not relevant and protect with the underscore when they are? This agrees with style(9). Andrew To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message