From owner-svn-src-all@FreeBSD.ORG  Fri Aug 30 13:56:15 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id E006BEF8;
 Fri, 30 Aug 2013 13:56:15 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id D159B26EB;
 Fri, 30 Aug 2013 13:56:14 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA14730;
 Fri, 30 Aug 2013 16:56:12 +0300 (EEST)
 (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1VFPBM-0007uL-Bi; Fri, 30 Aug 2013 16:56:12 +0300
Message-ID: <5220A458.3060202@FreeBSD.org>
Date: Fri, 30 Aug 2013 16:55:36 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130810 Thunderbird/17.0.8
MIME-Version: 1.0
To: Hans Petter Selasky <hps@bitfrost.no>
Subject: Re: svn commit: r255067 - head/sys/kern
References: <201308301039.r7UAduI1052038@svn.freebsd.org>
 <5220A027.8070604@FreeBSD.org> <5220A2DD.5040803@bitfrost.no>
In-Reply-To: <5220A2DD.5040803@bitfrost.no>
X-Enigmail-Version: 1.5.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Aug 2013 13:56:16 -0000

on 30/08/2013 16:49 Hans Petter Selasky said the following:
> On 08/30/13 15:37, Andriy Gapon wrote:
>> on 30/08/2013 13:39 Hans Petter Selasky said the following:
>>> Author: hselasky
>>> Date: Fri Aug 30 10:39:56 2013
>>> New Revision: 255067
>>> URL: http://svnweb.freebsd.org/changeset/base/255067
>>>
>>> Log:
>>>    Simplify pause_sbt() logic. Don't call DELAY() if remainder is less
>>>    than or equal to zero.
>>
>> Discussed with?
>> Reviewed by?
>> Tested by?
>>
> 
> Hi,
> 
> I've checked MAINTAINERS first.
> 
> A patch was sent to the freebsd-current mailing list, See XHCI USB debugging
> thread.

I noticed that you committed the patch just a few minutes after making it
public.  And later noticed that the patch did not result in any improvement.

> Could probably have been discussed a bit more.

Indeed.

> The cold case logic for pause()
> is mainly used by the USB code and was factored out from usb_pause_mtx() a long
> while ago by me.

Oh, I see.

> Do you see anything technically wrong about my patch?

I don't feel qualified enough.

-- 
Andriy Gapon