Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Sep 2024 16:54:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 281521] security/libretls: fix build with clang 19
Message-ID:  <bug-281521-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281521

            Bug ID: 281521
           Summary: security/libretls: fix build with clang 19
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: bapt@FreeBSD.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(bapt@FreeBSD.org)
          Assignee: bapt@FreeBSD.org

Clang 19 has become more strict about function redefinitions, which
results in:

  compat/arc4random.c:197:1: error: redefinition of 'arc4random_buf'
    197 | arc4random_buf(void *buf, size_t n)
        | ^
  /usr/include/ssp/stdlib.h:38:22: note: previous definition is here
     38 | __ssp_redirect(void, arc4random_buf, (void *__buf, size_t __len),
        |                      ^

The problem is that the configure script "detects" arc4random_buf just
fine, due to the ports system passing ac_cv_func_arc4random_buf=3Dyes, but
it also has an overriding part:

  # fork detection missing, weak seed on failure
  #
https://svnweb.freebsd.org/base/head/lib/libc/gen/arc4random.c?revision=3D2=
68642&view=3Dmarkup
  USE_BUILTIN_ARC4RANDOM=3Dyes

I think both of these are no longer true, so delete these lines in
post-patch, which ensures that compat/arc4random.c is _not_ compiled at
all.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-281521-7788>