From owner-svn-src-all@FreeBSD.ORG Mon Aug 3 19:02:24 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 962201065673; Mon, 3 Aug 2009 19:02:24 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 60B5F8FC0A; Mon, 3 Aug 2009 19:02:24 +0000 (UTC) (envelope-from sam@errno.com) Received: from ice.local ([10.0.0.115]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n73J283c011632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Aug 2009 12:02:08 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4A773430.2050804@errno.com> Date: Mon, 03 Aug 2009 12:02:08 -0700 From: Sam Leffler User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605) MIME-Version: 1.0 To: Robert Watson References: <20090802192902.GS47463@elvis.mu.org> <20090803.012206.1492586399.imp@bsdimp.com> <20090804032402.J21599@delplex.bde.org> <200908032033.08169.hselasky@c2i.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-CollegeOfNewCaledonia-Metrics: ebb.errno.com; whitelist Cc: src-committers@FreeBSD.org, Bruce Evans , svn-src-all@FreeBSD.org, alfred@FreeBSD.org, Hans Petter Selasky , nparhar@gmail.com, svn-src-head@FreeBSD.org, "M. Warner Losh" Subject: Re: svn commit: r195960 - in head/sys/dev/usb: . controller input X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2009 19:02:25 -0000 Robert Watson wrote: > > On Mon, 3 Aug 2009, Hans Petter Selasky wrote: > >> On Monday 03 August 2009 19:46:16 Bruce Evans wrote: >>> On Mon, 3 Aug 2009, M. Warner Losh wrote: >>>> In message: <200908030827.21108.hselasky@c2i.net> >>>> >>>> : I see two solutions: >>>> : >>>> : 1) Disable the timekeeping if no keys are pressed. >>>> : >>>> : 2) Second option is to use getmicrotime. Actually what I need is >>>> just a >>>> : millisecond time reference so I know when to repeat the last key. >>>> : >>>> : Any opinions? DELAY() or getmicrotime() ? >>> >>> DELAY(1) is somewhet usable. >> >> I think DELAY(1) is not accurate enough. >> >> I suggest that the DELAY(1000) is only active while a key is actually >> pressed. >> >> See attached patch. Please test and report back. > > This seems a reasonable middle ground -- avoids use of sensitive time > counters in DDB, avoids expensive poll operation most of the time, and > allows key repeat to work, which is especially nice for backspace in > DDB. :-) I think we are losing sight of the goal here. We are in a release schedule and trying to find a minimal set of changes that resolves our immediate need. Keyboard repeat is not required and unless there is an obvious and immediate solution it should be considered AFTER the release. Remember we are already behind schedule for 8.0. Sam