Date: Wed, 27 Jun 2001 12:40:09 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: net@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: review request: network interface cloning Message-ID: <20010627124009.D12739@Odin.AC.HMC.Edu> In-Reply-To: <20010627111159.E2097@sunbay.com>; from ru@FreeBSD.ORG on Wed, Jun 27, 2001 at 11:12:00AM %2B0300 References: <20010626144313.A7909@Odin.AC.HMC.Edu> <20010627111159.E2097@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Thanks for the review.
On Wed, Jun 27, 2001 at 11:12:00AM +0300, Ruslan Ermilov wrote:
> Please don't use hard sentence breaks.
I'm, not sure what you mean by this. Do you mean, don't use ". " or
what? I've moved to split sentences by lines.
> Especially with the long getopt() list, it might be a good idea to put
> `case' statements in the same order as they were in getopt() call.
I've reordered the switch statement to be ordered like getopt. It's not
entierly right and Sheldon is correct that usage and the SYNOPSIS are
also misorderd, but I'm not going to fix that just now. There are lots
of problems with ifconfig and fixing them isn't really the point of this
patch. I'm actually thinking of taking a look at adding our local
extensions to the NetBSD ifconfig source and moving to that since they
have actually maintained it.
> You need to decide, memset(3) or bzero(3). :-)
memset looks more common so I'm using it now. Some bzeros remain in
unrelated parts of the code.
> > + err = (*ifc->ifc_create)(ifc, &unit);
> > + if (err != 0)
> > + return (err);
> > +
> if (err)
> return (err);
>
> is more traditional :-)
But err isn't a boolean and the example in style(9) is:
error = function(a1, a2);
if (error != 0)
exit(error);
The bug I documented in the gif manpage was caught and squashed so that
has been removed.
I've updated the diff at:
http://people.freebsd.org/~brooks/patches/gif.diff
-- Brooks
--
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE7OjaYXY6L6fI4GtQRAv9SAJ9yM2ydWxKe3mWdUrNSPat/0jKTGgCaA22p
z1cbc1x7Dj2iOuUZBwQqriY=
=Tw8F
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010627124009.D12739>