From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jun 26 11:20:12 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8272937B401 for ; Thu, 26 Jun 2003 11:20:12 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A6A943FEC for ; Thu, 26 Jun 2003 11:20:11 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5QIKBUp037299 for ; Thu, 26 Jun 2003 11:20:11 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5QIKBCl037298; Thu, 26 Jun 2003 11:20:11 -0700 (PDT) Resent-Date: Thu, 26 Jun 2003 11:20:11 -0700 (PDT) Resent-Message-Id: <200306261820.h5QIKBCl037298@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sergey Matveychuk Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A66A37B401; Thu, 26 Jun 2003 11:13:02 -0700 (PDT) Received: from harp.mtu.ru (harp.mtu.ru [212.188.8.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id C933E43F85; Thu, 26 Jun 2003 11:13:00 -0700 (PDT) (envelope-from sem@ciam.ru) Received: from hueymiccailhuitl.mtu.ru (hueytecuilhuitl.mtu.ru [195.34.32.123]) by harp.mtu.ru (Postfix) with ESMTP id 5A7F123F20; Thu, 26 Jun 2003 22:01:32 +0400 (MSD) Received: from sem-home.ciam.ru (ppp138-73.dialup.mtu-net.ru [62.118.138.73]) by hueymiccailhuitl.mtu.ru (Postfix) with ESMTP id 49ADDF891E; Thu, 26 Jun 2003 21:53:01 +0400 (MSD) (envelope-from sem@ciam.ru) Received: from sem by sem-home.ciam.ru with local (Exim 4.12) id 19Vavd-0000iB-00; Thu, 26 Jun 2003 21:53:01 +0400 Message-Id: Date: Thu, 26 Jun 2003 21:53:01 +0400 From: Sergey Matveychuk To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: ports@FreeBSD.org cc: kde@FreeBSD.org Subject: ports/53791: Can't pass CPPFLAGS to configure when WITH_QT_VER setted (patch) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Sergey Matveychuk List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2003 18:20:12 -0000 >Number: 53791 >Category: ports >Synopsis: Can't pass CPPFLAGS to configure when WITH_QT_VER setted (patch) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jun 26 11:20:10 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Sergey Matveychuk >Release: FreeBSD 5.1-RELEASE i386 >Organization: >Environment: System: FreeBSD sem-home.ciam.ru 5.1-RELEASE FreeBSD 5.1-RELEASE #0: Wed Jun 11 02:03:37 MSD 2003 root@sem-home.ciam.ru:/usr/src/sys/i386/compile/SEM-HOME i386 >Description: My port can build WITH_QT or without it. Also I pass CPPFLAGS to 'configure' by CONFIGURE_ENV. When I don't set WITH_QT all goes right, when I don't set it I loss CPPFLAGS in 'configure'. It's happened because these lines in bsd.kde.mk: CONFIGURE_ENV+= CPPFLAGS="${QTCPPFLAGS}" that overrides my CPPFLAGS settings. The followed patch fix it. I think it's unpainful for other KDE stuff. It's important for my port. So let me know if it's possible to commit it soon, please. >How-To-Repeat: >Fix: --- bsd.kde.mk.orig Thu Jun 26 21:17:13 2003 +++ bsd.kde.mk Thu Jun 26 21:20:36 2003 @@ -110,8 +110,9 @@ .if !defined (QT_NONSTANDARD) CONFIGURE_ARGS+=--with-extra-libs="${LOCALBASE}/lib" \ --with-extra-includes="${LOCALBASE}/include" -CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" \ - QTDIR="${QT_CVS_PREFIX}" KDEDIR="${KDE_CVS_PREFIX}" +CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" \ + LIBS="${QTCFGLIBS}" QTDIR="${QT_CVS_PREFIX}" \ + KDEDIR="${KDE_CVS_PREFIX}" .endif .elif ${USE_QT_VER} == 3 @@ -139,7 +140,8 @@ CONFIGURE_ARGS+=--with-qt-includes=${QT_PREFIX}/include \ --with-qt-libraries=${QT_PREFIX}/lib \ --with-extra-libs=${LOCALBASE}/lib -CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" +CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" \ + LIBS="${QTCFGLIBS}" .endif # !defined(QT_NONSTANDARD) .else # QT2 @@ -159,7 +161,7 @@ --with-qt-libraries=${X11BASE}/lib \ --with-extra-libs=${LOCALBASE}/lib CONFIGURE_ENV+= MOC="${MOC}" LIBQT="-l${QTNAME}" \ - CPPFLAGS="${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" + CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" .endif # !defined(QT_NONSTANDARD) .endif # USE_QT_VER == ??? >Release-Note: >Audit-Trail: >Unformatted: