From owner-svn-src-all@FreeBSD.ORG Fri Jan 8 16:45:32 2010 Return-Path: <owner-svn-src-all@FreeBSD.ORG> Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28AE11065676; Fri, 8 Jan 2010 16:45:32 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101]) by mx1.freebsd.org (Postfix) with ESMTP id 94E5C8FC20; Fri, 8 Jan 2010 16:45:31 +0000 (UTC) Received: from zim.MIT.EDU (localhost [127.0.0.1]) by zim.MIT.EDU (8.14.3/8.14.2) with ESMTP id o08GjUql062907; Fri, 8 Jan 2010 11:45:30 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by zim.MIT.EDU (8.14.3/8.14.2/Submit) id o08GjUp1062906; Fri, 8 Jan 2010 11:45:30 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Fri, 8 Jan 2010 11:45:30 -0500 From: David Schultz <das@FreeBSD.ORG> To: Jaakko Heinonen <jh@FreeBSD.ORG> Message-ID: <20100108164530.GA62775@zim.MIT.EDU> Mail-Followup-To: Jaakko Heinonen <jh@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <200912171703.nBHH3mEn041893@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200912171703.nBHH3mEn041893@svn.freebsd.org> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r200633 - head/usr.bin/uniq X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 08 Jan 2010 16:45:32 -0000 On Thu, Dec 17, 2009, Jaakko Heinonen wrote: > Sync getline() with comm(1): > > - Prevent overflowing of the buffer length variable in getline() by > limiting its maximum value. > - Exit if reallocf(3) fails in getline(). Failure was silently > considered as end-of-file. We should consider using getline(3) from libc, rather than hand-rolled versions of almost the same thing that are copy-pasted in multiple places. The only catch is I need to check in the wide character version of getline() I've had sitting in my tree for months. I'll try to get on that this weekend.