From owner-freebsd-current Mon Sep 10 18:44:55 2001 Delivered-To: freebsd-current@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id C43B137B401 for ; Mon, 10 Sep 2001 18:44:51 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id f8B1ij608212; Mon, 10 Sep 2001 19:44:50 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.3/8.11.4) with ESMTP id f8B1ijt29008; Mon, 10 Sep 2001 19:44:45 -0600 (MDT) (envelope-from imp@harmony.village.org) Message-Id: <200109110144.f8B1ijt29008@harmony.village.org> To: Mark Santcroos Subject: Re: ToPIC100 not working correctly Cc: current@FreeBSD.ORG In-reply-to: Your message of "Tue, 11 Sep 2001 02:00:00 +0200." <20010911020000.A519@laptop.6bone.nl> References: <20010911020000.A519@laptop.6bone.nl> <86n14cms6f.wl@e-ppp8.eken.phys.nagoya-u.ac.jp> <200109031624.f83GOVh26528@harmony.village.org> <20010904112524.A542@laptop.6bone.nl> <20010905115107.D28669@enterprise.spock.org> <20010906135053.C464@laptop.6bone.nl> <20010910215100.A578@laptop.6bone.nl> Date: Mon, 10 Sep 2001 19:44:45 -0600 From: Warner Losh Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20010911020000.A519@laptop.6bone.nl> Mark Santcroos writes: : On Mon, Sep 10, 2001 at 09:51:00PM +0200, Mark Santcroos wrote: : > Do you know the exact reason for this problem or can I help by exactly : > finding out what change of code causes this problems? : : I deciced to track it down. I narrowed it down to the commit to pcic_pci.c : v1.71. That's good to know. : diff /tmp/pccardd/current/pcic.c ./pcic.c : 897c897 : < return (bus_generic_teardown_intr(dev, child, irq, cookie)); : --- : > return 0; : diff /tmp/pccardd/current/pcic_pci.c ./pcic_pci.c : 1336c1336 : < DEVMETHOD(bus_teardown_intr, bus_generic_teardown_intr), : --- : > DEVMETHOD(bus_teardown_intr, pcic_teardown_intr), : : : IOW, just skip the bus_generic_teardown_intr(). I called it a workaround, : cause I don't know if this is really a fix or a hack. (Don't know the code : well enough for that) : However, my problems disappeared with this patch. : : Please shine your light on this, or give a suggestion for a nice fix. : Anyway, the fix seems close (and trivial). That's actually excellent information. That's about the best diagnosis I've had in a while. I'd rather have had a -u diff, but with such a small diff, I can easily try it here. There might be side effects that we'll need to take care of... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message