From owner-svn-src-all@freebsd.org Wed Jan 13 12:31:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC179A6BA8E; Wed, 13 Jan 2016 12:31:56 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ig0-x236.google.com (mail-ig0-x236.google.com [IPv6:2607:f8b0:4001:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9737A18A8; Wed, 13 Jan 2016 12:31:56 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ig0-x236.google.com with SMTP id z14so166727688igp.0; Wed, 13 Jan 2016 04:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=SZyfLWZYeyB2mzrgIO50Hpr4LDBNpub+h7cILBnm3GQ=; b=TGsNlU6dU/kJ/pLeHkTIOFYZUIXREli9uOOEs2UZBavKRw5rJejbXGiNVJynCPes9H yfirtUNONzIjd5mQlA5W8jjOwYZ8g5WRxL7dWec9RNenCAdggboAFz+WR1DOLZ1mZijs uBeIrsWTPKM2kO/sYv6q8uXAA5FSUbi+ET42gpG6vQHKQ77JVoyJ/aF7d0cGB9t8Hz6l 4m/yhXgj5iHwpu4WuqFF8rGWEKub/GynAnhAj2RVF7leT8ujBUqGbYcpHLbhL9kfgOs4 7/UmgO2t1puKiU2VS2KV/SvqRJRUFBajjvM8gdYaNcfDfUUYiaN93+dxwd1MYFKXTSOu p/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=SZyfLWZYeyB2mzrgIO50Hpr4LDBNpub+h7cILBnm3GQ=; b=nJVIlk9zPYUA1jdP50RsHzQR9MWj2G5X0f8do6VIhe3oyc+o5jDZjasMT5Zs3O01di MbqDY6d9P0euI2jyfr0zKgY+dzhfY/HIdficj2sa5RdsNwQhJiF5B0UW7O4gCQxp5Hv7 gdAj9RazQOqi6CxvwFMm+M+vjQx87eIH+1eGhb4jYH16kvUnQrHAoXhxvcdS73aJ52Ms Ar33ogi3ec2DiW7bUjASYlZQEkl8IpyZXKxysKeJEb3yzyWby+Mt7e6rtcSkg8vcq/mX /oVFteSmPXegECyL24o/l8WQTWdz6D8Q5SQMabz242arIp6a7huNhgpS4Gzj5pZjjBfO sfpQ== X-Gm-Message-State: ALoCoQnoApuaDnF+24agGRKfUzbLI3QeqnA2mzuQQiD7ax939yBuHaheF1mqULdvjlKqdG3x23wlZppF1WyQzDos2lWve2AFIQ== MIME-Version: 1.0 X-Received: by 10.50.143.108 with SMTP id sd12mr600251igb.12.1452688316009; Wed, 13 Jan 2016 04:31:56 -0800 (PST) Sender: sepherosa@gmail.com Received: by 10.107.166.3 with HTTP; Wed, 13 Jan 2016 04:31:55 -0800 (PST) In-Reply-To: References: <201601120130.u0C1UpvA074721@repo.freebsd.org> Date: Wed, 13 Jan 2016 20:31:55 +0800 X-Google-Sender-Auth: 02AytwlSSXSl0LhvVCYfmcp5ylA Message-ID: Subject: Re: svn commit: r293719 - head/sys/dev/hyperv/netvsc From: Sepherosa Ziehau To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 12:31:57 -0000 OH, sure, sorry about that, I will do it now. On Wed, Jan 13, 2016 at 6:49 PM, Bjoern A. Zeeb wrote: > On Tue, 12 Jan 2016, Sepherosa Ziehau wrote: > >> Author: sephe >> Date: Tue Jan 12 01:30:51 2016 >> New Revision: 293719 >> URL: https://svnweb.freebsd.org/changeset/base/293719 >> >> Log: >> hyperv/hn: Implement LRO >> >> - Implement the LRO using tcp_lro APIs, and LRO is enabled by default. > > > Which are only available if INET or INET6 are compiled into the kernel. > Unfortunately this breaks kernel builds that do not include IPv4 or IPv6 > support. > > Can you please put appropriate #if defined(INET6) || defined(INET) in > place? > > > >> Differential Revision: https://reviews.freebsd.org/D4824 >> >> Modified: >> head/sys/dev/hyperv/netvsc/hv_net_vsc.c >> head/sys/dev/hyperv/netvsc/hv_net_vsc.h >> head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c > > > hv_netvsc_drv_freebsd.o: In function `netvsc_recv': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x483): > undefined reference to `tcp_lro_rx' > hv_netvsc_drv_freebsd.o: In function `netvsc_recv_rollup': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x5ce): > undefined reference to `tcp_lro_flush' > hv_netvsc_drv_freebsd.o: In function `netvsc_attach': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x901): > undefined reference to `tcp_lro_init' > hv_netvsc_drv_freebsd.o: In function `netvsc_detach': > /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0xca8): > undefined reference to `tcp_lro_free' > --- kernel --- > *** [kernel] Error code 1 > bmake: stopped in /storage/head/obj/scratch/tmp/bz/head.svn/sys/LINT-NOIP > > >> head/sys/dev/hyperv/netvsc/hv_rndis.h >> head/sys/dev/hyperv/netvsc/hv_rndis_filter.c >> head/sys/dev/hyperv/netvsc/hv_rndis_filter.h -- Tomorrow Will Never Die