From owner-cvs-all Sat Dec 18 11:42: 7 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 090B214D8F; Sat, 18 Dec 1999 11:41:50 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id EE8D31CA0; Sun, 19 Dec 1999 03:41:46 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: Brian Fundakowski Feldman Cc: Warner Losh , Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Kernel broken (was: Re: cvs commit: src/lib/libc/gen fts.c) In-Reply-To: Message from Brian Fundakowski Feldman of "Sat, 18 Dec 1999 12:38:03 EST." Date: Sun, 19 Dec 1999 03:41:46 +0800 From: Peter Wemm Message-Id: <19991218194147.EE8D31CA0@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Brian Fundakowski Feldman wrote: > On Sat, 18 Dec 1999, Warner Losh wrote: > > > In message Bria n Fundakowski Feldman writes: > > : What do you object to? In my analysis of the changes, I didn't notice > > : anything bad. The only difference I can think of objecting to would > > : be reversion to using realloc() instead of reallocf(), but the code > > : works the same either way. > > > > Using realloc instead of reallocf introduces a memory leak when the > > system can't realloc the memory. > > They use realloc() and explicit freeing. You know, I'd be a lot happier if you would concentrate on fixing where you have broken the kernel: uipc_mbuf.o: In function `m_mballoc_wait': uipc_mbuf.o(.text+0x2cf): undefined reference to `m_mballoc_wakeup' uipc_mbuf.o: In function `m_clalloc_wait': uipc_mbuf.o(.text+0x3f7): undefined reference to `m_clalloc_wakeup' Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message